Bug 387556 - Window to create a new vault shows Wayland generic icon
Summary: Window to create a new vault shows Wayland generic icon
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords: wayland
Depends on:
Blocks:
 
Reported: 2017-12-03 12:28 UTC by Patrick Silva
Modified: 2020-01-16 23:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (55.15 KB, image/png)
2017-12-03 12:28 UTC, Patrick Silva
Details
plasma 5.18 beta (101.86 KB, image/png)
2020-01-16 23:49 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-03 12:28:12 UTC
Created attachment 109192 [details]
screenshot

start plasma Wayland session and click on vault icon in system tray to create a new vault. See my screenshot.
Comment 1 Patrick Silva 2018-01-19 18:27:58 UTC
plasma 5.12 beta is affected.
Comment 2 miku84 2018-02-09 10:31:42 UTC
Same happens for Clementine and Krusader apps for example.
Comment 3 Ivan Čukić 2018-02-10 09:07:39 UTC
Git commit 45ad41edad0df1d118317cba9497c02fb1b3870d by Ivan Čukić.
Committed on 10/02/2018 at 09:07.
Pushed by ivan into branch 'Plasma/5.12'.

Set icons for the Vault creation, configuration and mounting dialogues

M  +3    -0    kded/ui/mountdialog.ui
M  +3    -0    kded/ui/vaultconfigurationwizard.ui
M  +3    -0    kded/ui/vaultcreationwizard.ui

https://commits.kde.org/plasma-vault/45ad41edad0df1d118317cba9497c02fb1b3870d
Comment 4 Ivan Čukić 2018-02-10 09:09:57 UTC
Thanks for reporting this. If it still shows the wayland icon, please reopen.
Comment 5 Patrick Silva 2018-02-13 18:46:44 UTC
icon is still wrong in plasma 5.12.1, Arch Linux.
Comment 6 Patrick Silva 2018-05-18 21:51:21 UTC
icon is still wrong in plasma 5.13 beta, Arch Linux.
Comment 7 Patrick Silva 2018-10-09 21:48:17 UTC
Still valid for plasma 5.14 on Arch Linux.
Comment 8 Patrick Silva 2019-02-14 16:47:25 UTC
Bug persists.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.0
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1
Comment 9 Ivan Čukić 2019-03-23 13:53:57 UTC
As soon as the patch goes through, the icon will be changed. Now, it can not be a Vault icon because of how Wayland operates, but it will not be a Wayland icon anymore.
Comment 10 David Edmundson 2019-04-07 15:35:28 UTC
Git commit 496b785f2218c240326c7c98d47bede4b140f3bf by David Edmundson.
Committed on 07/04/2019 at 15:35.
Pushed by davidedmundson into branch 'master'.

Install .desktop file for kded5

Summary:
This is useful as on wayland setting a path to a desktop file is
mandatory for icons on any windows. Qt sets the app_id to org.kde.kde5
but this desktop file doesn't exist.

We do a similar fix in plasmashell and other services that don't really
map to the traditional application pattern.

I set the type to something other than Application so we don't have to
put an Exec line though it wouldn't really matter as it's hidden anway.

Test Plan:
Opened a vault
Got an icon

Reviewers: ivan

Reviewed By: ivan

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19986

M  +1    -0    CMakeLists.txt
A  +7    -0    org.kde.kded5.desktop

https://commits.kde.org/kded/496b785f2218c240326c7c98d47bede4b140f3bf
Comment 11 Patrick Silva 2019-05-17 16:21:28 UTC
Wayland generic icon persists on Plasma 5.16 beta.
Comment 12 Patrick Silva 2019-09-19 19:42:07 UTC
This issue persists on Plasma 5.17 beta.

Operating System: Arch Linux 
KDE Plasma Version: 5.16.90
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1
Comment 13 Patrick Silva 2020-01-16 23:49:18 UTC
Created attachment 125188 [details]
plasma 5.18 beta

now we have a KDE generic icon :)

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0