Bug 387483 - Elegant theme: Selected frame colors swapped [patch]
Summary: Elegant theme: Selected frame colors swapped [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-HTMLGallery (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-30 21:57 UTC by Alexander Potashev
Modified: 2018-04-05 04:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0.0
Sentry Crash Report:
caulier.gilles: Junior_Jobs+


Attachments
patch to fix inverted colors (1.39 KB, patch)
2017-12-01 04:08 UTC, caulier.gilles
Details
selectedFrameColor for background-color selectedFrameBorderColor for border (1.10 KB, patch)
2018-04-04 19:46 UTC, Veluri Mithun
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2017-11-30 21:57:51 UTC
In the HTML export "Elegant" theme
 - the variable named selectedFrameColor has effect on the border,
 - the variable named selectedFrameBorderColor has effect on the background color.
Should be the other way around.


See in digikam/data/htmlgallery/themes/elegant/template.xsl:

    #content li a {
        background-color: <xsl:value-of select="$frameColor"/>;
        border: 1px solid <xsl:value-of select="$frameBorderColor"/>;
    }

    #content li a:hover {
        border: 1px solid <xsl:value-of select="$selectedFrameColor"/>;
        background-color: <xsl:value-of select="$selectedFrameBorderColor"/>;
    }
Comment 1 caulier.gilles 2017-12-01 04:08:08 UTC
Created attachment 109141 [details]
patch to fix inverted colors

If you look well in CSS customization of Elegant theme, more than one properties are inverted. See my patch for details.
Comment 2 Alexander Potashev 2017-12-01 12:39:57 UTC
(In reply to caulier.gilles from comment #1)
> Created attachment 109141 [details]
> patch to fix inverted colors
> 
> If you look well in CSS customization of Elegant theme, more than one
> properties are inverted. See my patch for details.

Thanks Gilles!

"1px solid" should always appear in the "border:" attribute, you mistakenly introduced some "background-color: 1px solid [...]" lines in your patch.
Comment 3 caulier.gilles 2017-12-17 16:33:50 UTC
Alexander,

What's the right patch well ? I'm not sure to understand

Gilles Caulier
Comment 4 Veluri Mithun 2018-04-04 19:46:09 UTC
Created attachment 111829 [details]
selectedFrameColor for background-color

selectedFrameBorderColor for border
Comment 5 Veluri Mithun 2018-04-04 19:47:50 UTC
(In reply to Veluri Mithun from comment #4)
> Created attachment 111829 [details]
> give selectedFrameColor for a:hover 'background-color' and selectedFrameBorderColor for a:hover 'border'
Comment 6 caulier.gilles 2018-04-05 04:50:57 UTC
Git commit c7a1cccb53b8f85840a439801846148046be182b by Human Dynamo.
Committed on 05/04/2018 at 04:48.
Pushed by cgilles into branch 'master'.

apply patch #111829 from Veluri Mithun to fix Elegan theme from image gallery
FIXED-IN: 6.0.0

M  +4    -4    core/data/htmlgallery/themes/elegant/template.xsl

https://commits.kde.org/digikam/c7a1cccb53b8f85840a439801846148046be182b