Bug 387470 - Comments unreadable in scripter under default theme
Summary: Comments unreadable in scripter under default theme
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Scripting (show other bugs)
Version: 4.0 pre-alpha
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-30 13:49 UTC by Brendan
Modified: 2017-12-04 16:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan 2017-11-30 13:49:26 UTC
Python hash comments:
# a comment
are rendered in a dark green against a dark grey in the default krita colour scheme. The colours make the comments very difficult to read. 

Triple quote comments:
""" a comment"""
are only slightly better, being dark pink
Comment 1 wolthera 2017-12-04 16:35:57 UTC
Git commit f095d09f46f401e3177a005c2712fc014d956c44 by Wolthera van Hövell tot Westerflier.
Committed on 04/12/2017 at 16:32.
Pushed by woltherav into branch 'master'.

Add background and foreground to the style syntax.

It technically doesn't belong with the style syntax, but from
a color palette design point of view, it does belong there
because it isn't possible to get always contrasting colors if you
cannot control which background to use. Leading to sometimes unreadable
comments or syntax highlighting.

M  +1    -1    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/actions/settingsaction/settingsdialog.py
M  +10   -2    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/actions/settingsaction/syntaxstylescombobox.py
M  +14   -4    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/editor/pythoneditor.py
M  +4    -0    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/syntax/syntaxstyles.py
M  +5    -1    plugins/extensions/pykrita/plugin/plugins/scripter/uicontroller.py

https://commits.kde.org/krita/f095d09f46f401e3177a005c2712fc014d956c44