Bug 387424 - Layers and Reviews categories use the same icon ("draw-freehand")
Summary: Layers and Reviews categories use the same icon ("draw-freehand")
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.1.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-29 00:54 UTC by Nate Graham
Modified: 2018-04-16 13:14 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Both categories use the same icon (18.84 KB, image/png)
2017-11-29 00:54 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-11-29 00:54:20 UTC 
Created attachment 109106 [details]
Both categories use the same icon

See attached screenshot. Will submit a patch soon.
Comment 1 Nate Graham 2017-11-29 01:54:20 UTC 
Patch at https://phabricator.kde.org/D9043
Comment 2 Albert Astals Cid 2017-12-03 19:52:38 UTC 
And you commited your patch, only to master and forgot to close this bug.

Please pay more attention to detail when developing.

Bugfixes like this go to stable branches.

I'll close the bug manually.
Comment 3 Nate Graham 2017-12-03 19:54:28 UTC 
Sorry, I thought the bug would get closed automatically because I added "BUG: 387424" to the pPhabricator revision.

In general, should I always ask which branch to commit to, or always commit to the latest stable branch and then merge to master, or do something else?
Comment 4 Luigi Toscano 2017-12-03 20:09:32 UTC 
(In reply to Nate Graham from comment #3)
> Sorry, I thought the bug would get closed automatically because I added
> "BUG: 387424" to the pPhabricator revision.

The line is "Summary: BUG: 387424", and that's probably why it was not parsed.

> In general, should I always ask which branch to commit to, or always commit
> to the latest stable branch and then merge to master, or do something else?

As Albert wrote: bugfixes (no features, no string changes (but exceptions are possible), etc) can go directly to the stable branch (and then merge to master). Anything else to master.
Comment 5 Nate Graham 2017-12-03 20:10:55 UTC 
Ok, thanks!