Bug 387415 - PlasmaComponents2.ComboBox in RTL shows wrong the selected item
Summary: PlasmaComponents2.ComboBox in RTL shows wrong the selected item
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.40.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-28 19:37 UTC by Michail Vourlakos
Modified: 2017-12-05 17:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michail Vourlakos 2017-11-28 19:37:53 UTC
When using the PlasmaComponents ComboBox in RTL the selected item of the combobox is shown at the left even though it should shown at the right
Comment 1 Michail Vourlakos 2017-11-28 21:10:14 UTC
More info about that...

The alignment of the Selected option in Combobox is identified by the language used for that specific option... This is wrong in my opinion because if the user has a list of options containing both English words and RTL ones then the selected text is moved for some of them to the left and for some of them to the right.

In my opinion a check of type:

> Qt.application.layoutDirection === Qt.RightToLeft

should be sufficient
Comment 2 Michail Vourlakos 2017-11-29 21:59:25 UTC
just checked that this issue is not appearing with QML standard ComboBox so this is plasma components issue.
Comment 3 Michail Vourlakos 2017-12-05 17:13:54 UTC
Git commit 71f8f16fea15973bdf98a621610b7e2b891dfa77 by Michail Vourlakos.
Committed on 05/12/2017 at 17:13.
Pushed by mvourlakos into branch 'master'.

[RTL] - align properly the selected text for RTL

Summary:
--align selected text correctly for
PlasmaComponents2.ComboBox taking into account
RTL.

Test Plan:
use ComboBoxes in RTL and LTR in order
to check a proper behavior

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D9126

M  +1    -0    src/declarativeimports/plasmastyle/ComboBoxStyle.qml

https://commits.kde.org/plasma-framework/71f8f16fea15973bdf98a621610b7e2b891dfa77