Bug 387402 - Allow Viewing of all screenshot previews in one popup in discover
Summary: Allow Viewing of all screenshot previews in one popup in discover
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 5.11.3
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-28 14:30 UTC by Kapil
Modified: 2017-12-11 17:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
single screenshot in a single popup (309.72 KB, image/png)
2017-11-28 14:30 UTC, Kapil
Details
I made some changes so that we can swipe between screenshots using mouse or press left/right keys to move between different screenshots (521.59 KB, image/png)
2017-11-28 14:36 UTC, Kapil
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kapil 2017-11-28 14:30:15 UTC
Created attachment 109094 [details]
single screenshot in a single popup

It would be nice if we could just view all screenshots of an addon in a fixed size single popup having a horizontal list of screenshots or something like that instead of clicking each thumbnail and then closing it to view another screenshot.
Comment 1 Kapil 2017-11-28 14:36:29 UTC
Created attachment 109096 [details]
I made some changes so that we can swipe between screenshots using mouse or press left/right keys to move between different screenshots

Does it look good, should i create a patch?
Comment 2 Aleix Pol 2017-11-29 13:55:31 UTC
I agree, don't create a patch, I have something on the pipeline.
Comment 3 Kapil 2017-11-29 15:40:36 UTC
(In reply to Aleix Pol from comment #2)
> I agree, don't create a patch, I have something on the pipeline.

ok, I will wait.
Comment 4 Aleix Pol 2017-12-11 17:14:01 UTC
Git commit 571265a864d1451d7dc03a8c4dd614ae17122656 by Aleix Pol.
Committed on 11/12/2017 at 17:13.
Pushed by apol into branch 'Plasma/5.11'.

Make it possible to navigate screenshots from the overlay

Otherwise we had to close it and open the next one

M  +39   -1    discover/qml/ApplicationScreenshots.qml

https://commits.kde.org/discover/571265a864d1451d7dc03a8c4dd614ae17122656