Bug 387284 - Brighness Key Show When Brightness is 100%
Summary: Brighness Key Show When Brightness is 100%
Status: RESOLVED FIXED
Alias: None
Product: Powerdevil
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-24 23:20 UTC by Andres Betts
Modified: 2018-05-24 13:42 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.14.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2017-11-24 23:20:35 UTC
When volume up key is pressed and you reach 100% it shows a dialog on the screen that it is at 100%. This is not the case with brightness. If your display is at 100% brightness already and you press the brightness function key, the dialog doesn't appear.

The expected behavior is that the brightness dialog will show up to show you that you are at 100% already.
Comment 1 Andres Betts 2018-01-01 19:28:46 UTC
Any interest here?
Comment 2 Kai Uwe Broulik 2018-01-01 21:51:49 UTC
Could be done, I suppose.
Comment 3 Andres Betts 2018-01-02 00:28:43 UTC
Thanks Kai. Let me know if I can help with anything in this request.

Andy
Comment 4 Nate Graham 2018-01-02 00:32:01 UTC
I'll add it onto the pile of things to take a look.
Comment 5 Thomas Surrel 2018-05-22 06:56:55 UTC
I just sent a patch for this: https://phabricator.kde.org/D13030
Comment 6 Nate Graham 2018-05-24 13:42:39 UTC
Git commit 4b8ae4d708a6f4cc854ea82ca96987f0b47ea722 by Nate Graham, on behalf of Thomas Surrel.
Committed on 24/05/2018 at 13:42.
Pushed by ngraham into branch 'master'.

Display brightness OSD even when min and max is reached

Summary:
When the brightness is already at the maximum (or minimum) value,
hitting the keyboard shortcut to increase (resp. decrease) it does
not bring up the OSD, there is no visual feedback.
This is not consistent either with the volume which handles this
correctly.
FIXED-IN: 5.14.0

Reviewers: ngraham, romangg

Reviewed By: ngraham, romangg

Subscribers: romangg, ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13030

M  +2    -2    daemon/powerdevilbrightnesslogic.cpp

https://commits.kde.org/powerdevil/4b8ae4d708a6f4cc854ea82ca96987f0b47ea722