Bug 387211 - Discover needs notification for required reboots
Summary: Discover needs notification for required reboots
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-22 15:28 UTC by Rick
Modified: 2018-04-20 17:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-9977-0.html (1.64 KB, text/html)
2017-11-22 23:37 UTC, Rick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rick 2017-11-22 15:28:21 UTC
Discover does not notify the user that a reboot is required to implement certain updates. Kernel and some other system updates require reboot. The developers should determine which updates require reboot and notify the user.
Comment 1 Nate Graham 2017-11-22 23:13:45 UTC
Where aren't you seeing notifications? On Neon and Kubuntu, I get them. There's a little pop-up in the corner, and then there's a little rotating arrow icon in the system tray until you reboot. You don't see those?
Comment 2 Rick 2017-11-22 23:37:50 UTC
Created attachment 109020 [details]
attachment-9977-0.html

No I didn't. I didn't see anything on my wife's PC either.

On Wed, Nov 22, 2017 at 5:13 PM, Nate Graham <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=387211
>
> Nate Graham <pointedstick@zoho.com> changed:
>
>            What    |Removed                     |Added
> ------------------------------------------------------------
> ----------------
>                  CC|                            |pointedstick@zoho.com
>          Resolution|---                         |WAITINGFORINFO
>              Status|UNCONFIRMED                 |NEEDSINFO
>
> --- Comment #1 from Nate Graham <pointedstick@zoho.com> ---
> Where aren't you seeing notifications? On Neon and Kubuntu, I get them.
> There's
> a little pop-up in the corner, and then there's a little rotating arrow
> icon in
> the system tray until you reboot. You don't see those?
>
> --
> You are receiving this mail because:
> You reported the bug.
>
Comment 3 Patrick Silva 2017-11-23 02:06:20 UTC
discover also shows no notification on my neon dev unstable despite my report is marked as "fixed".
https://bugs.kde.org/show_bug.cgi?id=381812
Comment 4 Nate Graham 2017-11-23 02:09:23 UTC
The commit that fixed that issue went in after the branch for 5.11.3, so it should show up in 5.11.4. I'm going to mark this as a dupe of that, and let's hope it's fixed in 5.11.4. If you still see it once you've got 5.11.4, please re-open that bug.

*** This bug has been marked as a duplicate of bug 381812 ***
Comment 5 Aleix Pol 2017-11-25 20:32:12 UTC
This duplicate is wrong. This bug report is about how we don't tell the user that she needs to reboot, not about the available updates notification.
Comment 6 Aleix Pol 2017-11-26 00:42:30 UTC
Git commit d91eb6d359a177e732051104b2500879023a7599 by Aleix Pol.
Committed on 26/11/2017 at 00:39.
Pushed by apol into branch 'Plasma/5.11'.

Make it possible for updaters to show notifications at any time

M  +1    -0    discover/qml/UpdatesPage.qml
M  +1    -1    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +1    -0    libdiscover/resources/ResourcesUpdatesModel.h

https://commits.kde.org/discover/d91eb6d359a177e732051104b2500879023a7599
Comment 7 Aleix Pol 2017-12-19 15:27:49 UTC
Git commit 5ac9d0b740279f8ed32778cbff23ce74a04a8907 by Aleix Pol.
Committed on 19/12/2017 at 15:23.
Pushed by apol into branch 'master'.

Add a persistant notification when pk says a reboot is required

M  +2    -2    libdiscover/backends/PackageKitBackend/CMakeLists.txt
M  +51   -2    libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp
M  +5    -1    libdiscover/backends/PackageKitBackend/PackageKitNotifier.h

https://commits.kde.org/discover/5ac9d0b740279f8ed32778cbff23ce74a04a8907