Bug 387155 - Does not compile on 'KDE Neon'
Summary: Does not compile on 'KDE Neon'
Status: RESOLVED WORKSFORME
Alias: None
Product: kreenshot-editor
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR critical
Target Milestone: ---
Assignee: Gregor Mi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-20 15:26 UTC by Malte Ketelsen
Modified: 2020-12-24 04:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte Ketelsen 2017-11-20 15:26:42 UTC
I get this errors when i try to compile on 'KDE Neon':

```
~/kreenshot-editor-master/build$ make
[  1%] Automatic moc for target kreenshot-editor
[  1%] Built target kreenshot-editor_automoc
[  3%] Automatic moc for target kreenshoteditor
[  3%] Built target kreenshoteditor_automoc
[prepare-include-files.sh] start (first argument is INC_TARGET_DIR)
[prepare-include-files.sh] pwd=/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor
[prepare-include-files.sh] INC_TARGET_DIR=generated-include
[prepare-include-files.sh] HEADER_SRC=kreenshoteditor.h
[prepare-include-files.sh] HEADER_TRT=kreen
[prepare-include-files.sh] TARGET_DIR=generated-include/kreen
[prepare-include-files.sh] fill (flatten subdirs)
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/kreenshoteditor.h
[prepare-include-files.sh] HEADER_SRC=core
[prepare-include-files.sh] HEADER_TRT=kreen/core
[prepare-include-files.sh] TARGET_DIR=generated-include/kreen/core
[prepare-include-files.sh] fill (flatten subdirs)
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/settingsmanager.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/documentfile.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/settingsgroupoutput.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/desktopservices.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/errorstatus.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/kreenitem.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.h
[prepare-include-files.sh] HEADER_SRC=ui
[prepare-include-files.sh] HEADER_TRT=kreen/ui
[prepare-include-files.sh] TARGET_DIR=generated-include/kreen/ui
[prepare-include-files.sh] fill (flatten subdirs)
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/ui/widgets/kreentoolbutton.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/ui/maineditorwidget.h
[prepare-include-files.sh] HEADER_SRC=util
[prepare-include-files.sh] HEADER_TRT=kreen/util
[prepare-include-files.sh] TARGET_DIR=generated-include/kreen/util
[prepare-include-files.sh] fill (flatten subdirs)
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/util/exportutil.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/util/sharedptrutil.h
[prepare-include-files.sh] create symlink to /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/util/pimplutil.h
[prepare-include-files.sh] check if cleaning is required...
[prepare-include-files.sh] no.
[  3%] Built target prepare-include-files
[  5%] Building CXX object src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/core/document.cpp.o
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtGlobal:1:0,
                 from /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/generated-include/kreen/util/exportutil.h:22,
                 from /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.h:22,
                 from /home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:19:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp: In member function ‘void kreen::core::Document::contentChangedNotificationGroupEnd()’:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:242:14: error: ‘d’ was not declared in this scope
     Q_ASSERT(d->contentChangedNotificationGroupDepth > 0);
              ^
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp: In member function ‘void kreen::core::Document::deleteItem(kreen::core::KreenItemPtr, bool)’:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:301:14: error: ‘d’ was not declared in this scope
     Q_ASSERT(d->itemMap.contains(item->id()));
              ^
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp: In member function ‘void kreen::core::Document::itemStackLowerStep(kreen::core::KreenItemPtr)’:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:333:14: error: ‘d’ was not declared in this scope
     Q_ASSERT(d->itemMap.contains(item_in->id()));
              ^
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp: In member function ‘bool kreen::core::Document::hasItemPropertiesChanged(kreen::core::KreenItemPtr)’:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:358:14: error: ‘d’ was not declared in this scope
     Q_ASSERT(d->itemMap.contains(item->id()));
              ^
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp: In member function ‘bool kreen::core::Document::applyItemPropertyChanges(kreen::core::KreenItemPtr, bool)’:
/home/malte/kreenshot-editor-master/src/lib/kreenshoteditor/core/document.cpp:366:14: error: ‘d’ was not declared in this scope
     Q_ASSERT(d->itemMap.contains(item->id()));
              ^
src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/build.make:142: die Regel für Ziel „src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/core/document.cpp.o“ scheiterte
make[2]: *** [src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/core/document.cpp.o] Fehler 1
CMakeFiles/Makefile2:211: die Regel für Ziel „src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/all“ scheiterte
make[1]: *** [src/lib/kreenshoteditor/CMakeFiles/kreenshoteditor.dir/all] Fehler 2
Makefile:138: die Regel für Ziel „all“ scheiterte
make: *** [all] Fehler 2
```
Comment 1 Gregor Mi 2017-11-20 19:24:07 UTC
Thanks for the report. I didn't update the code for quite some time. The prepare-include-files.sh is a bit hacky and should be replaced by a more standard construct.

I didn't know the project is being packaged. This is good news. Can you tell me how the package got into KDE Neon? :)
Comment 2 Malte Ketelsen 2017-11-20 19:26:13 UTC
I'm sorry, my mistake. There are no packages for this.
Comment 3 null 2018-02-06 14:14:36 UTC
@wbauer has a patch in his openSUSE packages for Kreenshot Editor, fixing the compilation issues: https://build.opensuse.org/package/view_file/home:wolfi323:branches:KDE:Frameworks5/kreenshot-editor/fix-build.patch
Comment 4 Malte Ketelsen 2018-02-06 17:03:56 UTC
(In reply to Henrik Fehlauer from comment #3)
> @wbauer has a patch in his openSUSE packages for Kreenshot Editor, fixing
> the compilation issues:
> https://build.opensuse.org/package/view_file/home:wolfi323:branches:KDE:
> Frameworks5/kreenshot-editor/fix-build.patch

Thanks, that helped.
Comment 5 Justin Zobel 2020-11-24 05:03:11 UTC
(In reply to Malte Ketelsen from comment #4)
> (In reply to Henrik Fehlauer from comment #3)
> > @wbauer has a patch in his openSUSE packages for Kreenshot Editor, fixing
> > the compilation issues:
> > https://build.opensuse.org/package/view_file/home:wolfi323:branches:KDE:
> > Frameworks5/kreenshot-editor/fix-build.patch
> 
> Thanks, that helped.

Can this now be resolved?

I've set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks.
Comment 6 Bug Janitor Service 2020-12-09 04:34:08 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2020-12-24 04:34:57 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!