Bug 387126 - unreachable code warning with nsl_geom_linesim.c
Summary: unreachable code warning with nsl_geom_linesim.c
Status: RESOLVED FIXED
Alias: None
Product: LabPlot2
Classification: Applications
Component: backend (other bugs)
Version First Reported In: latest
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Stefan Gerlach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-19 18:13 UTC by uwestoehr
Modified: 2017-11-19 21:52 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/labplot/f73d02b47eadae04b12d3454044e19ab05b08a9b
Version Fixed/Implemented In: 2.5
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description uwestoehr 2017-11-19 18:13:19 UTC 
I get:

4>c:\craftroot\labplot\src\backend\nsl\nsl_geom_linesim.c(275): warning C4701: potentially uninitialized local variable 'newmaxdist' used
4>c:\craftroot\labplot\src\backend\nsl\nsl_geom_linesim.c(603): warning C4702: unreachable code
Comment 1 Stefan Gerlach 2017-11-19 19:06:36 UTC 
should be fixed in the latest commit.
Comment 2 Alexander Semke 2017-11-19 19:12:25 UTC 
Hi Stefan,

wenn Du in der Commit-Message die Bugnummer angibst, wird das Ticket 
automatisch geschlossen. Mit FIXED-IN: 2.5 wird auch gleich der Richtige 
Release angegeben. Also


BUG: 387126

FIXED-IN: 2.5


Oder hast Du das jetzt extra nicht angegeben, weil Du Uwe überprüfen 
lassen möchtest?


Grüße,

ich


On 19.11.2017 20:06, Stefan Gerlach wrote:
> https://bugs.kde.org/show_bug.cgi?id=387126
>
> Stefan Gerlach <stefan.gerlach@uni-konstanz.de> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>       Ever confirmed|0                           |1
>               Status|UNCONFIRMED                 |CONFIRMED
>             Assignee|alexander.semke@web.de      |stefan.gerlach@uni-konstanz
>                     |                            |.de
>                   CC|                            |stefan.gerlach@uni-konstanz
>                     |                            |.de
>
> --- Comment #1 from Stefan Gerlach <stefan.gerlach@uni-konstanz.de> ---
> should be fixed in the latest commit.
>
Comment 3 uwestoehr 2017-11-19 20:48:24 UTC 
The unreachable code warning is gone, but now I get:

4>C:\CraftRoot\labplot\src\backend\nsl\nsl_geom_linesim.c(645): warning C4244: 'function': conversion from 'double' to 'const std::size_t', possible loss of data
4>C:\CraftRoot\include\msvc\stdlib.h(53): warning C4255: 'random': no function prototype given: converting '()' to '(void)'
Comment 4 Stefan Gerlach 2017-11-19 21:26:50 UTC 
Git commit f73d02b47eadae04b12d3454044e19ab05b08a9b by Stefan Gerlach.
Committed on 19/11/2017 at 21:25.
Pushed by sgerlach into branch 'master'.

FIXED-IN: 2.5

M  +1    -1    src/backend/nsl/nsl_geom_linesim.c

https://commits.kde.org/labplot/f73d02b47eadae04b12d3454044e19ab05b08a9b
Comment 5 uwestoehr 2017-11-19 21:52:01 UTC 
Thanks, it is now fixed.