Bug 387070 - Bristle engine creates artifacts when drawn on negative coords in wrap around mode
Summary: Bristle engine creates artifacts when drawn on negative coords in wrap around...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush Engine/Bristle (other bugs)
Version First Reported In: 3.3.2
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-18 14:30 UTC by Alvin Wong
Modified: 2019-11-09 05:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
artifacts (287.78 KB, image/png)
2017-11-18 14:30 UTC, Alvin Wong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2017-11-18 14:30:34 UTC
Created attachment 108948 [details]
artifacts

The preset Bristle_Squared displays the behaviour easily.

Actually, it seems to also produce some artifacts inside the main canvas, but it's much worse when outside and on negative coordinates.
Comment 1 Halla Rempt 2017-11-23 09:26:44 UTC
Sounds like there are rounding errors when converting the coordinates.
Comment 2 Alvin Wong 2017-11-23 09:30:13 UTC
Just fyi, neither https://phabricator.kde.org/D8894 nor https://phabricator.kde.org/D8898 seem to change anything regarding the bristle engine,
Comment 3 mvowada 2018-01-20 18:31:19 UTC
(I can confirm on Ubuntu 14.04 - Krita 4.0.0-beta1.1.appimage)
Comment 4 vanyossi 2019-05-22 05:21:49 UTC
Git commit d3175ce38f93b651addb935ad7ee6ccb19c8720b by Ivan Yossi.
Committed on 22/05/2019 at 05:20.
Pushed by ivany into branch 'master'.

Fix Bristle artifacts on Wrap Around mode

Only avoids artifacts being more prominent on wraparound mode

M  +4    -4    plugins/paintops/hairy/hairy_brush.cpp

https://invent.kde.org/kde/krita/commit/d3175ce38f93b651addb935ad7ee6ccb19c8720b
Comment 5 Halla Rempt 2019-05-23 12:17:35 UTC
Git commit d678560c7d79a169cf8b3e1c9b28a6afd9fa708b by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 23/05/2019 at 11:57.
Pushed by rempt into branch 'krita/4.2'.

Fix Bristle artifacts on Wrap Around mode

Only avoids artifacts being more prominent on wraparound mode

M  +4    -4    plugins/paintops/hairy/hairy_brush.cpp

https://invent.kde.org/kde/krita/commit/d678560c7d79a169cf8b3e1c9b28a6afd9fa708b
Comment 6 vanyossi 2019-11-09 05:52:00 UTC
Setting as fixed as negative coordinate artifacts is no longer an issue