Bug 387036 - Scrollview-within-a-scrollview paradigm is sub-optimal
Summary: Scrollview-within-a-scrollview paradigm is sub-optimal
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
Depends on:
Reported: 2017-11-17 14:26 UTC by Nate Graham
Modified: 2017-11-17 16:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Screenshot (217.48 KB, image/png)
2017-11-17 14:26 UTC, Nate Graham

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-11-17 14:26:13 UTC
Created attachment 108916 [details]

When using Discover to perform software updates, each package can be clicked to display the package's changelog (if available). However the changelog is embedded within a scrollview, which leads to a situation where there are scrollviews within a larger scrollview. This causes two usability issues:

- The scrollview is short and wide, making it hard to actually read the content
- Your cursor can easily find itself above a package changelog scrollview and get its focus stolen when you are reying to scroll the list of packages

I recommend taking the package changelogs out of their scrollviews and just display the full content in a non-scrolling view as tall as necessary if the user clicks on it.
Comment 1 Nate Graham 2017-11-17 15:11:45 UTC
Proof-of-concept patch available at https://phabricator.kde.org/D8869

The patch may not be quite the right way to implement this change, but hopefully it illustrates the general idea.
Comment 2 Nate Graham 2017-11-17 16:20:24 UTC
Git commit 732a0ffb2ab0cac9778ea490098ddad02ece824d by Nathaniel Graham.
Committed on 17/11/2017 at 16:14.
Pushed by ngraham into branch 'master'.

Don't use a scrollview to display package changelogs


Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).

Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.

Test Plan:
Tested in KDE Neon. Package changelogs are now fully visible without being in a tiny scrollview:


Reviewers: #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8869

M  +5    -8    discover/qml/UpdatesPage.qml