Bug 386933 - Incorrect name for pc file an library in it
Summary: Incorrect name for pc file an library in it
Status: CONFIRMED
Alias: None
Product: frameworks-activities-stats
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.40.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-15 02:45 UTC by rezso
Modified: 2018-04-07 10:09 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rezso 2017-11-15 02:45:52 UTC
The package contains an libKActivitiesStats.pc.cmake, which defines an non-existant -lKActivitiesStats lib, and the pc file is installed as libKActivitiesStats.pc. The correct names are libKF5ActivitiesStats.pc, and -lKF5ActivitiesStats.
If the pc file is needed, please fix this.
Comment 1 groot 2017-11-29 07:46:57 UTC
Note that KActivities (the other framework) **also** contains a .pc file, which is called `libKActivities.pc` .. so that's a similarly wrongly-named file. The description in both files names them wrongly, the URL could be upgraded to https, and in my installed (to a DESTDIR) version of the framework, the *libs* line looks like this:

```
    Libs: -Llib -lKActivitiesStats
```

That does not seem like a useful setting for the -L flag; other pc files from KDE Frameworks provide a full (prefix) path. The *requires* line is also missing Qt5Core.

So there's more to fix than just the name.
Comment 2 Christophe Marin 2017-11-29 07:54:12 UTC
OK, renaming the .pc files in these 2 repos wouldn't be source compatible (the impact in null as these 2 files are unusable in their current state)
Comment 3 Christophe Marin 2017-11-29 08:23:34 UTC
Git commit 3a24cde223aeeaf3b50dc3054d9ba12eb39a0e0e by Christophe Giboudeaux.
Committed on 29/11/2017 at 08:23.
Pushed by cgiboudeaux into branch 'master'.

Start fixing libKActivitiesStats.pc:

- Add a working version string,
- Require Qt5Core,
- Use the correct library name when linking

M  +3    -3    src/libKActivitiesStats.pc.cmake

https://commits.kde.org/kactivities-stats/3a24cde223aeeaf3b50dc3054d9ba12eb39a0e0e
Comment 4 Christophe Marin 2017-11-29 08:26:02 UTC
I'm not closing the report. I didn't rename the file (yet). 
I need more opinions first.