Bug 386902 - Cannot close reviews page and open review dialog
Summary: Cannot close reviews page and open review dialog
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-11-14 12:37 UTC by Jan Grulich
Modified: 2018-01-17 19:37 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/discover/e152796b00eb333dbedc7bfee87b9f96027304e8
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Grulich 2017-11-14 12:37:56 UTC 
When I open reviews page (list of reviews) then I'm not able to close it. I can close it only when I click on the button back or when I press "esc" key. I remember it was possible to just swipe it away or click somewhere in the area around. Also, when I invoke the review dialog within reviews page then the dialog is not visible, it only changes background behind the reviews page. My guess is that the review dialog is opened underneath.
Comment 1 Aleix Pol 2017-12-11 16:42:03 UTC 
Git commit e152796b00eb333dbedc7bfee87b9f96027304e8 by Aleix Pol.
Committed on 11/12/2017 at 16:41.
Pushed by apol into branch 'Plasma/5.11'.

Hide reviews page when opening the review dialog

Sometimes the reviews page would be on top, also improves the usability
of the dialog.

M  +1    -0    discover/qml/ReviewsPage.qml

https://commits.kde.org/discover/e152796b00eb333dbedc7bfee87b9f96027304e8