Bug 386850 - Kirigami apps have dark labels when using dark theme
Summary: Kirigami apps have dark labels when using dark theme
Status: RESOLVED NOT A BUG
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-13 11:02 UTC by Jan Grulich
Modified: 2017-11-13 11:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Screenshot of plasma discover (335.46 KB, image/png)
2017-11-13 11:02 UTC, Jan Grulich 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Grulich 2017-11-13 11:02:29 UTC 
Created attachment 108835 [details]
Screenshot of plasma discover

When using a dark theme I can barely see some labels in Kirigami apps. This is most visible when using Plasma Discover. There is also a bug 384638 opened for system settings which I think is caused by the same problem.
Comment 1 Marco Martin 2017-11-13 11:05:42 UTC 
hmm, i'm pretty sure our labels colors are ok, does discover does something about labels colors?
Comment 2 Jan Grulich 2017-11-13 11:09:58 UTC 
You can ignore this, I should have checked the discover source code first as those invisible labels are actually QQC2.Label.
Comment 3 Jan Grulich 2017-11-13 11:10:50 UTC 
It looks correct when I set:
color: Kirigami.Theme.textColor
Comment 4 Marco Martin 2017-11-13 11:29:37 UTC 
(In reply to Jan Grulich from comment #3)
> It looks correct when I set:
> color: Kirigami.Theme.textColor

qqc2.label should also have the correct color, if the proper style, qqc2-desktop-style is used
Comment 5 Jan Grulich 2017-11-13 11:37:06 UTC 
You are right. I installed qqc2-desktop-style and that fixed my issue. We apparently don't have this packaged in Fedora yet.