Bug 386551 - Status & Notifications and Digital Clock can be tiled
Summary: Status & Notifications and Digital Clock can be tiled
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: master
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-05 14:07 UTC by vamartid
Modified: 2020-01-09 15:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vamartid 2017-11-05 14:07:26 UTC
First of all I am sorry if this is not the right place to file this bug...please forgive me if I chose the wrong one.
Images are the easiest way to describe this so:
this image is before tiled to left
https://imgur.com/dpHnCSl.png
this is after the tiling
https://imgur.com/U5nsE2l.png
now...I don't think it is supposed to be tiled this way... but if it is,
there must also be a way for the user to set the size to this back to normal or to any size preferred.
The tiling is done by shortcuts set from the Global Shortcuts->KWin->Quick Tile Window ...
Comment 1 Christoph Feck 2017-11-24 02:06:00 UTC
These popups are also moveable with Alt+Left, while e.g. popup menus are not, so there must be some setting that informs the window manager that these are not regular application windows.
Comment 2 Konrad Materka 2020-01-08 16:48:56 UTC
This applies to all applets (full representation). I tested it with Analog clock (calendar) and with Clipboard (added as separate applet, not only system tray).

Issue is probably in the PlasmaCore.Dialog implementation.
Comment 3 Konrad Materka 2020-01-09 15:50:00 UTC
Git commit 4a65dcefe494b8db915c6d6ac075c70528ff8113 by Konrad Materka.
Committed on 09/01/2020 at 15:49.
Pushed by kmaterka into branch 'master'.

[SystemTray] Set maximum size to block tiling

Summary:
System tray dialog/popup can be tiled. This should not be allowed, in this case expanded representaiton should have fixed size. When tiled, it is no longer possible to restore original size.
This also applies to other plasmoids.
FIXED-IN: 5.18.0

Test Plan:
1. Open any applet from system tray (for example Clipboard or hidden items)
2. Use shortcut to tile window (by default Meta + Left/Righ/...)
3. Applet will change size and tile at the borded of the screen
4. Expected:
a) before fix: allowed and not possible to restore size
b) after fix: not allowed or restores size on next open

Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26545

M  +2    -0    applets/digital-clock/package/contents/ui/CalendarView.qml
M  +3    -1    applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

https://commits.kde.org/plasma-workspace/4a65dcefe494b8db915c6d6ac075c70528ff8113
Comment 4 Konrad Materka 2020-01-09 15:52:15 UTC
System tray should be fine now.
For digital clock, it still possible to tile, but on next show (hide and click on the click again) it should show with original size.

FYI, if you accidentally tile a window, use the same shortcut again (few times if you have multiple screens). It should restore the original size.