Bug 386517 - Gwenview slideshow mode should only inhibit screen locking and sleep when the app is in the foreground
Summary: Gwenview slideshow mode should only inhibit screen locking and sleep when the...
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 16.12.3
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-11-04 07:54 UTC by Holger
Modified: 2023-03-31 15:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 23.04
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger 2017-11-04 07:54:19 UTC
Steps to reproduce:
- enable Kscreenlocker (set a short timeout to speedup tests)
- start Gwenview and enable fullscreen via F11
- Alt+Tab to some other program

Although Gwenview lost focus, it still prevents the screen from locking. Especially, if you left Gwenview on another desktop, you could easily forget, that your screen won't lock, if you go away. You have to explicitly lock it manually by Ctrl+Alt+L.

Don't get me wrong: blocking Kscreenlocker while in front is totally appreciated. But please release the block, if not the focused window.
Comment 1 Holger 2017-11-04 17:43:42 UTC
Confirmed with 17.04.3

BTW: Should the version field contain the earliest version or the latest affected version?
Comment 2 Nate Graham 2017-11-05 02:43:41 UTC
Earliest.
Comment 3 Patrick Silva 2017-11-05 13:53:32 UTC
same on neon dev unstable.
Comment 4 Justin Zobel 2022-11-18 04:30:39 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 5 Patrick Silva 2022-11-20 10:36:06 UTC
Can reproduce on neon unstable.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Graphics Platform: Wayland
Comment 6 Nate Graham 2022-11-21 22:00:38 UTC
This appears to be intentional; Gwenview is deliberately setting an inhibition, which is listed in the Battery & Brightness widget. I guess it figures that a slideshow isn't the kind of thing during which you don't want to have your screen locked.

But it could clear the inhibition when it's not the frontmost app, yeah.
Comment 7 Bug Janitor Service 2023-03-31 00:31:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/gwenview/-/merge_requests/191
Comment 8 Nate Graham 2023-03-31 14:34:24 UTC
Git commit 3f2ea85dc50c6930b2b67f10254a598ececc05dd by Nate Graham, on behalf of Nikita Karpei.
Committed on 31/03/2023 at 14:33.
Pushed by ngraham into branch 'master'.

Inhibit screen locking and sleep only when the app is in the foreground

M  +14   -0    app/mainwindow.cpp
M  +2    -0    app/mainwindow.h

https://invent.kde.org/graphics/gwenview/commit/3f2ea85dc50c6930b2b67f10254a598ececc05dd
Comment 9 Nate Graham 2023-03-31 14:34:51 UTC
Git commit a2268f497fefd4277d9abc1393d48d31d63df066 by Nate Graham, on behalf of Nikita Karpei.
Committed on 31/03/2023 at 14:34.
Pushed by ngraham into branch 'release/23.04'.

Inhibit screen locking and sleep only when the app is in the foreground


(cherry picked from commit 3f2ea85dc50c6930b2b67f10254a598ececc05dd)

M  +14   -0    app/mainwindow.cpp
M  +2    -0    app/mainwindow.h

https://invent.kde.org/graphics/gwenview/commit/a2268f497fefd4277d9abc1393d48d31d63df066