Bug 386377 - Context menu search doesn't obey default search engine setting
Summary: Context menu search doesn't obey default search engine setting
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-31 02:36 UTC by Kishore Gopalakrishnan
Modified: 2018-01-01 17:11 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/falkon/8749c05854bbf33d5bc5df2d767d529326ea1d30
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2017-10-31 02:36:39 UTC 
Steps to reproduce:
1. Change the default search engine from duckduckgo to something else (eg. Google).
2. Select text on any page and right-click

Observed result:
The main search entry in the context menu still offers to search with duckduckgo. The default search engine is accessible only via the submenu for other search engines.

Expected result:
The main entry should offer to search with the default search engine set by the user.

Version information:
Distro: Arch Linux
I'm using the falkon-git AUR package.
Info from 'help>about Falkon':
"
Application version 2.1.99 (4d006b56)
QtWebEngine version 5.9.2
© 2010-2017 David Rosca
https://www.qupzilla.com
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Falkon/2.1.99 Chrome/56.0.2924.122 Safari/537.36
"
Comment 1 David Rosca 2018-01-01 17:11:20 UTC 
Git commit 8749c05854bbf33d5bc5df2d767d529326ea1d30 by David Rosca.
Committed on 01/01/2018 at 17:09.
Pushed by drosca into branch 'master'.

WebView: Search using default engine instead of active in actions

M  +4    -4    src/lib/webengine/webview.cpp

https://commits.kde.org/falkon/8749c05854bbf33d5bc5df2d767d529326ea1d30