Bug 386360 - "ok/close" buttons in dialog to confirm connection deletion need to use more appropriate terms
Summary: "ok/close" buttons in dialog to confirm connection deletion need to use more ...
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Unmaintained
Component: kcm (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-30 15:08 UTC by Patrick Silva
Modified: 2017-10-31 12:51 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-nm/e7b1b68eacc453d89c5d31a60a7627c21effeabc
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
screenshot (17.80 KB, image/png)
2017-10-30 15:08 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-10-30 15:08:31 UTC 
Created attachment 108643 [details]
screenshot

My summary says by itself, see the screenshot.

I use opensuse krypton, plasma-nm 5.11.90git.20171029T033943~7553bbf9-15.1
Comment 1 Nate Graham 2017-10-30 19:59:57 UTC 
Actually, Yes/No buttons are never recommended because they don't tend to be descriptive enough to let the user know what to do, and most users only read the buttons rather than the text.

Better button names would be Remove/Keep, or something like that. Should be pretty simple, I'll see if I can put together a patch sometime soon.
Comment 2 Patrick Silva 2017-10-31 00:55:16 UTC 
(In reply to Nate Graham from comment #1)
> Better button names would be Remove/Keep

Good idea. 
Thank you Nate.
Comment 3 Nate Graham 2017-10-31 02:19:34 UTC 
Turns out this dialog is a QML MessageDialog, which as far as I can tell can't take custom buttons, and there's no standard button with the label "Remove." Hmm.
Comment 4 Nate Graham 2017-10-31 02:39:05 UTC 
Ok/Cancel will have to do. Patch available: https://phabricator.kde.org/D8562
Comment 5 Nate Graham 2017-10-31 12:51:55 UTC 
Git commit e7b1b68eacc453d89c5d31a60a7627c21effeabc by Nathaniel Graham.
Committed on 31/10/2017 at 12:51.
Pushed by ngraham into branch 'master'.

Use standard Ok/Cancel buttons for the connection removal dialog

Summary:

Change the Close button to a Cancel button in the KCM's connection removal dialog.

Test Plan:
Tested in KDE Neon. The dialog now has Ok/Cancel buttons:

{F5459178}

Reviewers: #plasma, jgrulich

Reviewed By: jgrulich

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8562

M  +1    -1    kcm/qml/main.qml

https://commits.kde.org/plasma-nm/e7b1b68eacc453d89c5d31a60a7627c21effeabc