Bug 386335 - Use a different shortcut for right panel zoom to 100%
Summary: Use a different shortcut for right panel zoom to 100%
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: LightTable-Canvas (show other bugs)
Version: 5.8.0
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 21:26 UTC by Nate Graham
Modified: 2022-02-01 09:09 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-10-29 21:26:06 UTC
We are in the middle of trying to define a consistent shortcut for all KDE Applications' "Configure [application]" menu item (https://phabricator.kde.org/D8296), and the current favorite is Ctrl+Shift+Comma. The only other place in all of KDE that this is used is in DigiKam's "right panel zoom to 100%" action.

However, it seems like the right and left panels are permanently synced, because Configure DigiKam > Light Table > uncheck "Synchronize panels automatically" doesn't actually let them move and zoom independently. Maybe that's a bug?

Either way, can we consider changing or removing DigiKam's usage of Ctrl+Shift+Comma to support https://phabricator.kde.org/D8296?
Comment 1 Maik Qualmann 2017-10-29 22:03:27 UTC
No it's not a bug, it's turned on or off in the lighttable GUI via the toolbutton "Synchronize". We use Ctrl + Comma in digiKam for 100% zoom or for the right side Ctrl + Shift + Comma. The question is which key instead of Comma? Maybe the O (O == original), what do you think Gilles?

Maik
Comment 2 Nate Graham 2017-10-29 22:05:25 UTC
How about Ctrl+Period?
Comment 3 Maik Qualmann 2017-10-29 22:12:38 UTC
Yes, Ctrl + Period is also unused in digiKam. Would personally also tend to this solution.

Maik
Comment 4 null 2017-10-29 23:58:47 UTC
>> Configure DigiKam > Light Table > uncheck "Synchronize panels automatically"
>> doesn't actually let them move and zoom independently. Maybe that's a bug?
> it's not a bug, it's turned on or off in the lighttable GUI via the toolbutton
You are both right. I can reproduce as follows:
- check "Sync" in settings → "Sync" button pressed, images in sync
- uncheck "Sync" in settings, restart Light Table → "Sync" button not pressed, but images still in sync
- press "sync" button, unpress "sync" button again → only now images are not in sync anymore

(If you can confirm, I can file another bug, as this one should be about the shortcut…)
Comment 5 Maik Qualmann 2017-10-30 07:05:25 UTC
Whether the "Sync" button is activated or deactivated depends on whether the two images have the same orientation and size.

Maik
Comment 6 caulier.gilles 2017-10-30 07:25:37 UTC
This is my generic tip about keyboard shortcuts :

The reference for DK must be the most used softwares in photography. Here i don't talk about Darktable or another Linux tool. As DK is multi-platform, the reference will be something like an Adobe product as LR. The keyboard shortcuts for LR are very well documented here :

https://makeawebsitehub.com/adobe-lightroom-keyboard-shortcuts-cheat-sheet/

Users migration to Linux will be simplified following this rules...

Gilles
Comment 7 caulier.gilles 2017-10-30 07:27:56 UTC
If LR do not provide a kind of shortcuts a feature as DK light table, I don't have any objection to use Ctrl+Period by default. 

After all, this can be configured in settings dialog.

Gilles
Comment 8 null 2017-10-30 08:02:54 UTC
> Whether the "Sync" button is activated or deactivated depends
> on whether the two images have the same orientation and size.
FWIW, for the second image I used an exact copy of the first, so this should have been true. However, I still got the behaviour as described above.

> https://makeawebsitehub.com/adobe-lightroom-keyboard-shortcuts-cheat-sheet/
All I could find there was "Toggle between Loupe and 1:1 Zoom preview: Spacebar or Z", but no distinction between left and right image.

> If [...] I don't have any objection to use Ctrl+Period by default.
That's great news, thanks!

@Nate: Could you provide a patch against digiKam? We also might want to hold off with a KConfig change until digiKam has had a release containing the change.
Comment 9 Maik Qualmann 2017-10-30 11:25:37 UTC
Git commit 27fa27ee481ee174cd553216f58ccef5147cf425 by Maik Qualmann.
Committed on 30/10/2017 at 11:23.
Pushed by mqualmann into branch 'master'.

change the shortcut key for zoom 100% to (Shift) + Ctrl + Period
FIXED-IN: 5.8.0

M  +2    -1    NEWS
M  +1    -1    app/main/digikamapp.cpp
M  +1    -1    utilities/imageeditor/editor/editorwindow.cpp
M  +2    -2    utilities/lighttable/lighttablewindow.cpp

https://commits.kde.org/digikam/27fa27ee481ee174cd553216f58ccef5147cf425
Comment 10 Maik Qualmann 2017-10-30 11:37:41 UTC
Git commit 81c4ea2b0c0c23ce58e617c1f897344733477be6 by Maik Qualmann.
Committed on 30/10/2017 at 11:36.
Pushed by mqualmann into branch 'master'.

add new shortcut key for zoom 100% to the import tool

M  +1    -1    utilities/importui/main/importui.cpp

https://commits.kde.org/digikam/81c4ea2b0c0c23ce58e617c1f897344733477be6
Comment 11 Nate Graham 2017-10-30 12:53:38 UTC
Thank you so much!
Comment 12 Maik Qualmann 2018-03-03 16:26:48 UTC
*** Bug 391329 has been marked as a duplicate of this bug. ***
Comment 13 Maik Qualmann 2018-03-10 09:23:41 UTC
*** Bug 391655 has been marked as a duplicate of this bug. ***
Comment 14 null 2018-03-10 09:30:17 UTC
Maik: Sorry for those duplicates, it's now up to Kubuntu to fix this: https://phabricator.kde.org/T8154
Comment 15 Maik Qualmann 2018-04-12 08:24:42 UTC
*** Bug 393031 has been marked as a duplicate of this bug. ***
Comment 16 Maik Qualmann 2018-04-18 16:35:36 UTC
*** Bug 393259 has been marked as a duplicate of this bug. ***