Bug 386323 - Sort folders "english first"
Summary: Sort folders "english first"
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (other bugs)
Version First Reported In: 17.08.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 12:15 UTC by Yan
Modified: 2017-11-03 18:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
patch (456 bytes, patch)
2017-10-29 12:15 UTC, Yan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yan 2017-10-29 12:15:23 UTC
Created attachment 108629 [details]
patch

I have folders with russian names and of curse english ones. Everywhere english names go first (windows, macOS, gnome, xfce), so it's convinient.

I've looked at the source code of Dolphin and it uses QCollator. To handle this we should set american locale to collator. I'll attach a patch. (I've tested, it fixes the problem)

Kde File Chooser should be also fixed (I don't know where it's sources are)
Comment 1 Nate Graham 2017-10-29 21:32:21 UTC
Thanks for the patch! Patches in bug reports tend to get lost, so would you mind submitting this on https://phabricator.kde.org/?

Put the string "BUG: 386323" on its own line in the Summary section and then this bug will be automatically closed when your patch is merged.
Comment 2 Yan 2017-10-30 20:27:35 UTC
High I will send a patch if I can register on this site, but there is no such button. In the login page I face error "Incorrect password" despite the button is called "Login or register"
Comment 3 Nate Graham 2017-10-30 20:39:14 UTC
I believe you need to first create an account on http://identity.kde.org/, and then use those credentials to log into Phabricator. Sorry for not mentioning this before.
Comment 4 Nate Graham 2017-11-03 18:44:53 UTC
Based on comments on Phabricator, seems like this is WONTFIX. Sorry Yan! Better luck with your next patch. :)