Bug 386261 - Show "Downloaded From" by default in Dolphin
Summary: Show "Downloaded From" by default in Dolphin
Status: RESOLVED FIXED
Alias: None
Product: frameworks-baloo
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.39.0
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Pinak Ahuja
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 17:57 UTC by Nate Graham
Modified: 2017-10-31 12:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-10-27 17:57:41 UTC
Baloo knows how to display "Downloaded From" xattr data in Dolphin, but this information is hidden by default. Here's how to get it:

Show Information Panel > Right-click on preview > Configure... > Check "Downloaded From"

Basically nobody will ever find this, and Downloaded From information is not only very useful, but not visible unless applicable (i.e. when a downloaded file is selected). I propose that we turn this on by default.
Comment 1 Nate Graham 2017-10-27 18:24:09 UTC
I've submitted a patch for this: https://phabricator.kde.org/D8527
Comment 2 Nate Graham 2017-10-31 12:49:23 UTC
Git commit 16e77619ee73a6129f732ae2e8ab32baaa089b29 by Nathaniel Graham.
Committed on 31/10/2017 at 12:49.
Pushed by ngraham into branch 'master'.

Display "Downloaded From" by default, if file supports it

Summary:

By default, show "Downloaded From" information from files' extended attributes, if present. No change for files without the xattr.

Test Plan:
Tested in KDE Neon. Blew away dolphinrc and baloofileinformationrc, deployed the baloo-widgets change, rebuilt dolphin, downloaded a file using Chromium (which writes the user.xdg.origin.url xattr), opened Dolphin, navigated to the file, selected it, and turned on the Information panel. Downloaded From was visible. It was (correctly) not visible for any other file that lacked the user.xdg.origin.url xattr.

{F5453057}

Reviewers: #dolphin, #frameworks, broulik, dfaure, markg, vhanda

Reviewed By: markg, vhanda

Subscribers: vhanda

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D8527

M  +1    -2    src/metadatafilter.cpp

https://commits.kde.org/baloo-widgets/16e77619ee73a6129f732ae2e8ab32baaa089b29