Bug 386036 - Three minor bugs in Tellico 3.0.2
Summary: Three minor bugs in Tellico 3.0.2
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: 3.0.2
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on: 387053 387130
Blocks:
  Show dependency treegraph
 
Reported: 2017-10-21 18:44 UTC by ejr67
Modified: 2017-12-16 02:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
XML file and 2 screenshots (100.78 KB, application/x-7z-compressed)
2017-10-21 18:44 UTC, ejr67
Details
Screen-shot Bug #4 (32.43 KB, image/png)
2017-10-24 22:59 UTC, ejr67
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ejr67 2017-10-21 18:44:59 UTC
Created attachment 108489 [details]
XML file and 2 screenshots

Dear Robby,

Thank you very much for creating and maintaining Tellico.

The following are three minor bugs in Tellico v3.0.2. I'm not sure if they actually amount to "bugs" - they are definitely changes in software "behavio(u)r" since v2.3.12, and it bothers me a little (and may bother other Tellico users) that Tellico should have lost a few functions in the process. But maybe these changes were intentional...? I wouldn't rate any of them as urgent or important. This report is only meant to help you make v3 even better.

They all relate to a "Video Collection" file (but may affect other collection types as well) and should be very easy to reproduce. I am attaching an example file (.xml) to support the explanations below, and a couple of screenshots for Bugs #1 and 3 below.


1/ Field replication - Multi-selection

The default field values when editing multiple entries cannot be selected and it seems to be random (I can't understand the logic at least).

I sometimes want to replicate a number of fields from one video entry to another. Say, for example, I have created two video entries:
(i) Bambi - Director = Disney, Walt
(ii) Cinderella - Director = Disney
and I want to copy across "Disney, Walt" from Bambi to Cinderella (and supersede "Disney" as the Director for Cinderella). Of course, this is a simple example - in real life, I would have a significant number of fields to copy across, and/or long values in certain fields (e.g. a long list of subtitle languages) that I don't want to retype manually. And in real life, the fields for the second entry would most likely be empty.

In v2.3.12, the way I would do this was by selecting both entries, right-clicking, selecting "Edit Entries", going to "Other People" tab > Director. Because both entries have different values in the "Director" field, it would be grayed out and deselected by default. By selecting the field, I would override the value in that field in both entries with whatever value shows in that field.

Now, of course, for the purpose of doing this, the "default" value in the field matters - the whole purpose of doing this is to save me from having to re-type the value (say, for instance, a long list of subtitle languages).

In v2.3.12, I knew that I could get the default value to be taken from either entry by selecting this entry first, then selecting (Ctrl+Click on the list of entries) the second entry. In this example, if I clicked on Bambi, then Ctrl+Click on Cinderella, and Edit Entries, the default value for "Director" would be "Disney, Walt", then I would select (by ticking the check box) the Director field and it would replace the value in the Director field by "Disney, Walt" in both entries (i.e. mainly in Cinderella).

In v3.0.2, I don't seem to find a way of doing this any more. Regardless of the order of selection of entries (Bambi first or Cinderella first, then the other), it always shows "Disney" as the default value in the "Director" field. I don't understand how the default value is determined (from which entry it is taken).

Process to reproduce:
a) Open the attached xml file
b) Click on Bambi
c) Ctrl+Click on Cinderella
d) Right-click > Edit Entries
e) Go to the "Other People" tab
f) The default value in the Director field is "Disney"
g) Click on "Close"
h) Click on Cinderella
i) Ctrl+Click on Bambi
j) Right-click > Edit Entries
k) Go to the "Other People" tab
l) The default value in the Director field is "Disney"
m) Click on "Close"

Expected Result:
At step f) above, the default value should be (would have been in v2.3.12) "Disney, Walt" because Bambi was selected first and that's the value in the Director field for Bambi.


2/ Multiple selection from an external source

When "sourcing" entries from an external source, say IMDb, the list is reset in-between searches.

I sometimes want to create multiple entries from IMDb in one go. I could do this in v2.3.12, which I found quite handy, but I can't do this in v3.0.2 any more, because the list is reset in-between searches. What is the purpose of the "Clear" button in that case, since the result of the previous search is cleared automatically anyway?

Process to reproduce:
a) Open the attached xml file
b) Press Ctrl+I
c) Select "Search source: Internet Movie Database"
d) Populate "Search:" with "Bambi"
e) Click "Search"
f) It displays a list of results
g) Populate "Search:" with "Cinderella"
h) Click "Search"
i) It clears the result list for Bambi and displays the list of results for Cinderella

Expected Result:
At step i) above, I wouldn't have expected it to clear the list of results for Bambi, but to add the new results for Cinderella at the end (or at the beginning, it doesn't matter) of the existing list (for Bambi). If I want to clear the list of previous results, I can do this manually by clicking on the "Clear" button before the next search. This prevents me from selecting the "Bambi" and the "Cinderella" I want from the (common) list and adding them in one go, which is what I used to do in v2.3.12, and found quite handy - I need to search for Bambi first, select the one I want, click on "Add Entry", then run another search for Cinderella, and do the same - no big deal, but less handy (in my humble opinion).


3/ Display issue with filter

When applying a filter, the detailed information window is not refreshed or cleared.
This was not an issue in v2.3.12 because (if my memory serves - not sure any more...) when selecting a filter, it would show the list of images (covers) in the right-hand side, bottom window.

Process to reproduce:
a) Open the attached xml file
b) From the filters, select "All Directors"
c) It shows the list of both files
d) Select Bambi
e) It displays the information about "Bambi" in the bottom half
f) Now select "Disney" from the filter list on the left-hand side
g) It shows the list of entries matching the criterion, which is (correctly) "Cinderella" only
h) But in the bottom half, "Bambi" is still displayed, even though it does not match the criterion

Expected Result:
I don't know... but not h). Maybe just clear the bottom half? Or revert to how it used to work in v2.3.12, i.e. (I believe) display the list of images that match the criteria in the filter, which I found a nice feature. But it should not display the information for an entry that does not match the current filter criteria and is therefore not on the filtered list. I find this to be confusing.

Many thanks again, best regards,

Eric.
Comment 1 ejr67 2017-10-24 22:59:15 UTC
Created attachment 108551 [details]
Screen-shot Bug #4

Illustration for Bug #4
Comment 2 ejr67 2017-10-24 23:00:30 UTC
... I'll add a fourth minor bug to the list - which may not be a change since v2.3.12, i.e. this bug may (or may not, I can't remember) have already been present in the v2.3 version. And I'm attaching a new screenshot image to illustrate it.

4/ Confusion in the selection of filters

Again, this is not a serious bug, since there's a work-around. However, the behavio(u)r is not as expected.

Process to reproduce:
a) Open the attached xml file
b) In the list of filters, select "Disney"
c) Only "Cinderella" is displayed on the list of entries on the right-hand side (which is correct)
d) De-select "Disney" as a filter, by Ctrl+Clicking on "Disney" on the filter list - now, no filters are selected any longer
e) However, the list of entries on the right-hand side still only shows "Cinderella" (which is no longer correct - I think...) - please see attached picture.
f) Now click on "Disney" in the filter list again, so that's it's selected once again (please bear with me - this is to show something else in the following steps)
g) The list still only shows "Cinderella" (which is correct again)
h) Now click on the black arrow with a cross inside in the field next to the "Filter" button at the top
i) The list of entries reverts to the complete, unfiltered list of all entries (all two of them...)
j) However, "Disney" is still selected on the filter list
k) Now click on "Disney" in the filter list again
l) The list of entries does not change and still shows two entries

Expected Result:
There are two steps which are not as I would have expected.

At step e), because I have actually removed the filter by Ctrl-clicking on it at step d), I would have expected the list to revert to the list of all (two) entries instead on only "Cinderella". This change in filter selection is not detected as an event and/or taken into account.
Of course step h) is the (or "a") work-around, and I can revert to the complete list of entries and remove the filter by clicking on the black arrow at the top.

At step l), because I've just clicked on "Disney", I would expect the list of entries to show "Cinderella" only, which is the only entry matching the criterion. But because "Disney" was already selected as a filter, as per step j), even though the list of entries displayed was unfiltered, the program is confused, and it doesn't detect the re-selection of "Disney" as a filter, and it doesn't update the list to apply the filter.
The work-around here is to select another filter (e.g. "All Directors"), and re-select "Disney", and it works fine again.

Again, noting serious, but maybe you can look into this some day...

Many thanks, best regards,

Eric.
Comment 3 Christoph Feck 2017-10-25 13:49:43 UTC
It's best to use one ticket per issue, so they can be investigated and resolved independently.
Comment 4 Robby Stephenson 2017-11-19 21:14:13 UTC
> 2/ Multiple selection from an external source
> 
> When "sourcing" entries from an external source, say IMDb, the list is reset
> in-between searches.
> 
> I sometimes want to create multiple entries from IMDb in one go. I could do
> this in v2.3.12, which I found quite handy, but I can't do this in v3.0.2
> any more, because the list is reset in-between searches. What is the purpose
> of the "Clear" button in that case, since the result of the previous search
> is cleared automatically anyway?
> 
> Process to reproduce:
> a) Open the attached xml file
> b) Press Ctrl+I
> c) Select "Search source: Internet Movie Database"
> d) Populate "Search:" with "Bambi"
> e) Click "Search"
> f) It displays a list of results
> g) Populate "Search:" with "Cinderella"
> h) Click "Search"
> i) It clears the result list for Bambi and displays the list of results for
> Cinderella
> 
> Expected Result:
> At step i) above, I wouldn't have expected it to clear the list of results
> for Bambi, but to add the new results for Cinderella at the end (or at the
> beginning, it doesn't matter) of the existing list (for Bambi). If I want to
> clear the list of previous results, I can do this manually by clicking on
> the "Clear" button before the next search. This prevents me from selecting
> the "Bambi" and the "Cinderella" I want from the (common) list and adding
> them in one go, which is what I used to do in v2.3.12, and found quite handy
> - I need to search for Bambi first, select the one I want, click on "Add
> Entry", then run another search for Cinderella, and do the same - no big
> deal, but less handy (in my humble opinion).
There was a mailing list discussion on this one that resulted in the change, tracked in Bug 357799

I do see your point about this changing making the Clear button slightly pointless. Maybe that's a candidate for removal...
Comment 5 Robby Stephenson 2017-12-16 02:12:59 UTC
Git commit dbf091714d4d8c4e61428a33a75e9efd2a4cd807 by Robby Stephenson.
Committed on 16/12/2017 at 02:10.
Pushed by rstephenson into branch 'master'.

Do not clear Fetch Dialog when Search is clicked

Reverting fix for bug 357799. The dialog has a Clear button for a reason
and the workflow in the bug discussion still holds (personally) where I
expect the user to want to perhaps do a single search from mutiple data
sources for the same item and choose the one with the most appropriate
data.
Related: bug 357799
FIXED-IN: 3.2

M  +4    -0    ChangeLog
M  +0    -1    src/fetchdialog.cpp

https://commits.kde.org/tellico/dbf091714d4d8c4e61428a33a75e9efd2a4cd807
Comment 6 Robby Stephenson 2017-12-16 02:14:05 UTC
Closing the bug as the underlying comments are all addressed, some of which were tracked as dependency bugs.