Bug 386008 - WinTab interfered by synthesized touch events on Windows ver 1709 (Fall Creators Update)
Summary: WinTab interfered by synthesized touch events on Windows ver 1709 (Fall Creat...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tablets (tablet issues are only very rarely bugs in Krita!) (other bugs)
Version First Reported In: 3.3.1
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Alvin Wong
URL:
Keywords:
: 386276 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-21 02:03 UTC by Zach
Modified: 2017-11-03 14:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 3.3.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zach 2017-10-21 02:03:02 UTC
It came up after I updated my computer (Lenovo Yoga 520) to Windows 10, version 1709. Whenever I use the pen, while simultaneously pressing the keys (ctrl+z, spacebar, etc), it would not respond or simply stays in that function until I use a mouse to switch out of/use it.

I've tried downgrading Krita from ver 3.3.1 to 3.2 and even installing older  Wacom Feel drivers from version ISD_7.3.4-47 to 7.3.4-36, but it still shows the same problem. When I completely remove all instances of Wacom Feel driver; with my pen functioning as a bare minimum of a mouse pointer, the keys seems to behave normally.

I suspect it could be the Windows 10 update causing all these problems. I do hope you could look into it, before I consider the option of rolling back my windows update. Thank you in advance.
Comment 1 Alvin Wong 2017-10-21 10:52:21 UTC
I seem to see the same behaviour on Surface Pro 2017 with ver 1709 when using WinTab, but no such issues with Windows Ink, so it might not be a Wacom-WinTab-driver-specific bug.

I'm not sure if this was working as expected before 1709, but this definitely needs some investigation.
Comment 2 Alvin Wong 2017-10-21 12:35:57 UTC
Hi, would you mind testing these two configs?

1. In configure Krita, go to tablet settings and switch to Pointer Input (Windows Ink), then restart Krita and test it.
2. See if the Wacom Feel driver offers an option to disable "Windows Ink". If it does, disable it, go back to Krita tablet settings and switch back to WinTab, then restart Krita and test again.
Comment 3 Zach 2017-10-22 09:20:20 UTC
Hi, thank you so much! Just carrying out the first step did the trick. Does this mean wintab is obsolete?
Comment 4 Alvin Wong 2017-10-22 09:23:05 UTC
No.

Can you test config 2?

> 2. See if the Wacom Feel driver offers an option to disable "Windows Ink". If it does, disable it, go back to Krita tablet settings and switch back to WinTab, then restart Krita and test again.
Comment 5 Alvin Wong 2017-10-22 10:45:59 UTC
So, I suspect that MS decided \it is a good idea to synthesize touch events from pen input...

It goes like this:

1. Pen event is sent through WinTab and Windows Ink by the driver
2. Krita takes the pen event from WinTab
3. Windows sends pen pointer events to Krita (since no lower level Windows Ink APIs are in use), which are ignored
4. Something (I'd guess DefWindowProc) then synthesizes touch events, and then mouse events
5. This probably upsets KisInputManager in some way?

I'll try to do a bit more digging...
Comment 6 Alvin Wong 2017-10-22 13:51:05 UTC
Git commit 66bf329335dd9b8bbf23ca59e854e149b5ba112b by Alvin Wong.
Committed on 22/10/2017 at 13:44.
Pushed by alvinwong into branch 'krita/3.3'.

Fix WinTab pen action not released on Windows ver 1709

Windows starts synthesizing touch events from "unhandled" Windows Ink
pen events and causes the WinTab pen release event to be incorrectly
ignored. This is known to affect certain non-Intuos Wacom tablets and
N-Trig devices. (Pointer Input API is not affected.)

M  +0    -1    libs/ui/input/kis_input_manager.cpp

https://commits.kde.org/krita/66bf329335dd9b8bbf23ca59e854e149b5ba112b
Comment 7 Alvin Wong 2017-10-22 14:00:48 UTC
Git commit 74b771f12200cfa8653672f5bbfbd2ddf42972c1 by Alvin Wong.
Committed on 22/10/2017 at 14:00.
Pushed by alvinwong into branch 'master'.

Fix WinTab pen action not released on Windows ver 1709

Windows starts synthesizing touch events from "unhandled" Windows Ink
pen events and causes the WinTab pen release event to be incorrectly
ignored. This is known to affect certain non-Intuos Wacom tablets and
N-Trig devices. (Pointer Input API is not affected.)

M  +0    -1    libs/ui/input/kis_input_manager.cpp

https://commits.kde.org/krita/74b771f12200cfa8653672f5bbfbd2ddf42972c1
Comment 8 Halla Rempt 2017-10-28 08:40:34 UTC
*** Bug 386276 has been marked as a duplicate of this bug. ***