Bug 385972 - When there are no vaults, "Create a New Vault" button should be centered in its window
Summary: When there are no vaults, "Create a New Vault" button should be centered in i...
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-20 02:16 UTC by Nate Graham
Modified: 2017-12-01 13:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Button that should be centered (284.77 KB, image/png)
2017-10-20 02:16 UTC, Nate Graham
Details
Example of centered button in the Bluetooth plasmoid (67.52 KB, image/png)
2017-10-21 16:20 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-10-20 02:16:03 UTC
Created attachment 108465 [details]
Button that should be centered

The screenshot says it all. That button should be centered, not smooshed into the corner.
Comment 1 cryptodude 2017-10-20 14:01:00 UTC
I disagree. Don't really see any reason for this suggestion as, for instance, the 'add' button on activities is also left aligned. 

I wrote more on #385987
Comment 2 Nate Graham 2017-10-20 16:35:50 UTC
Perhaps I should be more explicit: I think it should only be in the center when there are no vaults. That makes it clear what you have to do to get started. Once there are some vaults, it makes sense to put it in the corner, where it is right now.
Comment 3 Nate Graham 2017-10-20 16:53:26 UTC
(that's the way the Bluetooth window is, for example)
Comment 4 Nate Graham 2017-10-21 16:20:19 UTC
Created attachment 108487 [details]
Example of centered button in the Bluetooth plasmoid
Comment 5 Paul 2017-10-21 17:08:26 UTC
I'm fairly neutral on this one, but was tending to agree with comment #1 ...

Until your comment #4 and seeing you meant vertically centred also :)

so, +1 for centred
Comment 6 cryptodude 2017-10-22 15:36:31 UTC
I retract my disagree in "comment 1" based on this new information, the intention of following the bluetooth screenshot sounds great to me for the single situation of not having anything there just yet.
Comment 7 Ivan Čukić 2017-10-29 17:38:36 UTC
+1 to this change. I have a few things to work on first, but this is a nice improvement idea.
Comment 8 Nate Graham 2017-10-29 17:40:50 UTC
Great! While you're at it, it might also be nice to give the button a plus icon--the standard symbol for "add something."
Comment 9 Ivan Čukić 2017-12-01 13:58:24 UTC
Git commit fef23f48913f1c7027f50da83e6137bb27bab10d by Ivan Čukić.
Committed on 01/12/2017 at 13:58.
Pushed by ivan into branch 'master'.

Better UI for the "Create a new vault" button

Summary:
The button to create a new vault now:
- has an icon "list-add"
- shows in the center of the applet when there are no existing vaults

Reviewers: #plasma, cryptodude, ngraham

Reviewed By: ngraham

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9045

M  +4    -0    plasma/package/contents/ui/main.qml

https://commits.kde.org/plasma-vault/fef23f48913f1c7027f50da83e6137bb27bab10d