Bug 385944 - Shouldn't translate several appstream fields
Summary: Shouldn't translate several appstream fields
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-19 10:56 UTC by Aleix Pol
Modified: 2018-01-24 10:44 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleix Pol 2017-10-19 10:56:10 UTC
https://cgit.kde.org/falkon.git/tree/linux/appdata/org.kde.Falkon.appdata.xml

<screenshot>, <url>, <updatecontact>, <metadata_license> and <id> shouldn't be translated.
Comment 1 Aleix Pol 2017-10-19 11:00:44 UTC
Git commit 94df7b7d4c3a85e4c33773e55f7bc4bb7fba15a3 by Aleix Pol.
Committed on 19/10/2017 at 10:57.
Pushed by apol into branch 'master'.

cmake is used now to build falkon, now it builds

It doesn't finalize, see bug

M  +2    -12   flatpak/org.kde.Falkon.json

https://commits.kde.org/falkon/94df7b7d4c3a85e4c33773e55f7bc4bb7fba15a3
Comment 2 David Rosca 2017-10-27 11:30:21 UTC
It's translated by scripty and I don't know how to tell him not to do it.
There is no Messages.sh script, so no translations at all should be done?
Comment 3 Aleix Pol 2017-10-27 13:53:45 UTC
No, description should be translated but not id. 

Here's the relevant tooling:
https://websvn.kde.org/trunk/l10n-kf5/scripts/extract_metainfo.sh?view=markup
https://websvn.kde.org/trunk/l10n-kf5/scripts/as-metainfo.its?revision=1395611&view=markup

I wonder why it only happens with Falkon... :/
Comment 4 David Rosca 2018-01-24 10:44:14 UTC
This is now fixed.