Bug 385907 - System settings has barely visible headers and labels on dark themes
Summary: System settings has barely visible headers and labels on dark themes
Status: RESOLVED DUPLICATE of bug 384638
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: 5.11.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-18 13:18 UTC by Jan Grulich
Modified: 2017-10-22 02:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Screenshot of new system settings (65.68 KB, image/png)
2017-10-18 13:18 UTC, Jan Grulich 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Grulich 2017-10-18 13:18:01 UTC 
Created attachment 108432 [details]
Screenshot of new system settings

When opening new system settings and using a dark theme I can barely see headers and labels on the main page, because it uses black text. I believe that system settings should be using color based on user's theme to make sure that the texts are always visible.
Comment 1 Nate Graham 2017-10-20 03:29:01 UTC 
Is this is Kirigami bug?
Comment 2 Nate Graham 2017-10-22 02:06:40 UTC 
No, this is a systemsettings bug, in sidebar/package/contents/ui/CategoriesPage.qml. The headers are implemented as list items with the "enabled: false" property, which causes the text to become much lighter. This seems like an abuse of the system, and precludes fine-grained control of the text color. It would be better if the headers were somehow styled as actual headers, not disabled items.
Comment 3 Nate Graham 2017-10-22 02:08:39 UTC 

*** This bug has been marked as a duplicate of bug 384638 ***