Bug 385861 - Add emblem to selection tool cursor to reflect current selection mode (add, subtract, etc.)
Summary: Add emblem to selection tool cursor to reflect current selection mode (add, s...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 3.3.1
Platform: Appimage Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-17 14:29 UTC by Amir Adar
Modified: 2018-09-05 17:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Amir Adar 2017-10-17 14:29:43 UTC
Using a selection tool, when switching between different selection modes (add, subtract, replace, etc.), if the user has the tool options as a button on the toolbar, there is no immediate indication of the current selection mode, which can be somewhat confusing.

Adding a small symbolic emblem for different modes, like "+" for add mode and "-" for subtract mode, can help the user see what mode the selection tool is currently on quickly and without opening any menus. An example of this behavior can be found in GIMP, when switching between the different selection mode or pressing Ctrl, Shift or Alt to change modes quickly.
Comment 1 Halla Rempt 2017-10-17 14:34:29 UTC
I don't think adding emblems to the icons in the toolbox is a good idea; it would add a completely new way of giving information to the user, and it would clutter up the toolbox visually.

What would be good, I think, would be to add this information to the selection indicator in the statusbar. That already gives selection state information, so extending that makes sense.
Comment 2 Amir Adar 2017-10-17 14:36:28 UTC
I meant to add the emblem to the cursor, which takes the shape of a selection tool when one is selected. Sorry, I should have been clearer
Comment 3 David REVOY 2017-10-17 14:44:45 UTC
I added the icons on May 2015 ( https://cgit.kde.org/krita.git/commit/?id=bdc4db9abea7b6ce8be97c5633ba802a9887ef1e ) but they never were linked to the action due to technical limitations at that time. Since this time, I poked probably two or three time about it but still this technical limitation. I remember a rewriting was necessary to support this type of feedback.
Comment 4 Halla Rempt 2017-10-17 14:52:21 UTC
Ah, right -- now I get it. I've edited the subject for clarification.
Comment 5 Amir Adar 2017-10-17 15:05:04 UTC
If this is cumbersome to implement, then perhaps adding these indicators to the status bar could serve as an adequate substitute.
Comment 6 Dmitry Kazakov 2018-09-05 17:38:15 UTC
Finally fixed in

https://cgit.kde.org/krita.git/commit/?id=a1dc9ad7494156cf79b225086bd0f941864baab7

:)