Bug 385835 - Files are unselected on drag&drop even if cancel is pressed later
Summary: Files are unselected on drag&drop even if cancel is pressed later
Status: CONFIRMED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.7.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords: reproducible, triaged
Depends on:
Blocks:
 
Reported: 2017-10-16 22:29 UTC by Toni Asensi Esteve
Modified: 2018-07-08 07:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Asensi Esteve 2017-10-16 22:29:54 UTC
After talking in a thread in the "krusader-users" mailing list, and later with Alex Bikadorov, it was agreed that:

- Files should be unselected after the operation is correctly finished. This is what Total Commander and Double Commander do by default; Midnight Commander also unselects files after the operations; Krusader 2.4 and Norton Commander did the same.

- Optionally, if there are enough people that want that their files are still selected after their operations, then a setting could be:
    [x] Unselect files after copy
(though any similar setting wasn't seen in Total Commander nor Double Commander nor Midnight Commander).

This is also important because nowadays: files are still selected after a copy operation, and so normally users have to unselect those files later, which is annoying (*).

(*) That would be solved nowadays if users set "Unselect files before copy/move" to true, but it would also have that effect nowadays: unwanted unselected files after a drag&drop.

Thanks for your attention :-)
Comment 1 Nikita Melnichenko 2018-02-18 06:10:52 UTC
Toni, can you share the link to krusader-users ML discussion?

Since "Unselect files before copy/move" is a feasible workaround, I'm moving this to wishlist for now.

I haven't got "but it would also have that effect nowadays: unwanted unselected files after a drag&drop" - why is this unwanted?
Comment 2 Toni Asensi Esteve 2018-02-19 17:11:30 UTC
> Toni, can you share the link to krusader-users ML discussion?

Yes, a link is https://groups.google.com/forum/#!msg/krusader-users/EAfQ8xyK938/U0npK5Q5BAAJ

> Since "Unselect files before copy/move" is a feasible workaround, I'm moving this to wishlist for now.

I wouldn't say so, we have also to take into account that new Krusader users (and Krusader users that do not know about this new subject) have to, manually, unselect files after every copy/move operation (as they are not aware of the "Unselect files before copy/move" checkbox) and they are used to work as Krusader did (and as Midnight Commander, Total Commander, etc. do). This is annoying for them :-(

> I haven't got "but it would also have that effect nowadays: unwanted unselected files after a drag&drop" - why is this unwanted?

If nowadays the user goes to
    Settings > Configure Krusader... > Panel
and checks "Unselect files before copy/move" then file deselections seems to work like in other programs (Total Commander, Midnight Commander) although... if he uses drag&drop, and cancels the operation, then the files are unselected (normally the user doesn't want that, because no copy/move operation was done).

Greetings!
Comment 3 Nikita Melnichenko 2018-02-19 22:24:28 UTC
I read the thread, tried myself and agree that current behavior is buggy with "Unselect files before copy/move" turned on (switching importance back). I'm not sure if "Unselect files after copy/move" will solve the usability problem completely, because these file ops are outsourced to background and user may want to move on before the actual process is done, especially for long copy ops.

I think we need to at least solve drag&drop problem described in the thread.
Comment 4 Toni Asensi Esteve 2018-02-21 17:42:08 UTC
> I think we need to at least solve drag&drop problem described in the thread.
Yes!
Comment 5 Nikita Melnichenko 2018-07-08 07:41:22 UTC
With "Unselect files before copy/move = Yes" if user uses drag&drop, and cancels the operation, then the files are unselected (normally the user doesn't want that, because no copy/move operation was done).