Bug 385794 - ActionItem.qml Label is wider than Button outline
Summary: ActionItem.qml Label is wider than Button outline
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-15 21:31 UTC by Chris Holland
Modified: 2017-10-25 16:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (14.35 KB, image/png)
2017-10-15 21:31 UTC, Chris Holland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Holland 2017-10-15 21:31:51 UTC
Created attachment 108366 [details]
screenshot

This is caused by the following bit. It shifts the actionText right but is still the same width as the parent.

    PlasmaComponents.Label {
        id: actionText

        anchors {
            left: actionIcon.right
            ...
        }
        width: parent.width
        ...
    }

Fix: anchors.right: parent.right
Optional: Refactor so the ActionItems aren't a "center column" and extend the ListView all the way to the right edge of VaultItem.
Comment 1 Nate Graham 2017-10-15 23:14:36 UTC
Thanks for finding this! Any chance you can submit a patch on https://phabricator.kde.org/? I'd be happy to help get you set up with an account if you could use a helping hand.
Comment 2 Chris Holland 2017-10-23 22:36:44 UTC
Git commit 0ad9e0a1fdc21d7ed6b82dbd19f472e4b17ff7d6 by Chris Holland.
Committed on 23/10/2017 at 22:36.
Pushed by cholland into branch 'master'.

Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size

Also includes a commented out mockup vaultsModel for use in plasmoidviewer.

Differential Revision: https://phabricator.kde.org/D8324

M  +1    -1    plasma/package/contents/ui/ActionItem.qml
M  +17   -2    plasma/package/contents/ui/main.qml

https://commits.kde.org/plasma-vault/0ad9e0a1fdc21d7ed6b82dbd19f472e4b17ff7d6