Bug 385683 - Krita clipboard not updating while using same vector selection.
Summary: Krita clipboard not updating while using same vector selection.
Status: CLOSED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: 3.3.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 385432 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-13 01:45 UTC by ryan
Modified: 2018-10-09 17:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
(Video Example) (1.79 MB, video/mp4)
2018-02-27 18:12 UTC, mvowada
Details
(Video: vector selection copy paste working after moving) (838.57 KB, video/mp4)
2018-03-02 14:55 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ryan 2017-10-13 01:45:19 UTC
This bug is similar to the one I posted for Krita 4.0 pre-alpha.

Additional copy and paste actions using the same Vector Selection results in non-updating image pastes. The clipboard does not update while using the same selection. 

If one selects a selection shape and changes it to Vector Selection and draws a selection around the pixels to be copied, only the first copy is committed to clipboard for pasting. This can be verified by moving the selection to another area and attempting to copy.

In addition, if one makes a a vector selection and moves the selection before copying, no copy will take place. 

Lastly, if one moves the selection too many times, the selection border will not update according to the coordinates of the transform box(blue) when using the shape manipulation tool to move.
Comment 1 Halla Rempt 2017-11-26 15:18:14 UTC
Can you please provide the link to that other bug so we can see whether it's a duplicate?

Also, this isn't exactly an easy set of steps to reproduce, so can you please be a bit more clear? I cannot follow this.
Comment 2 Halla Rempt 2017-11-26 15:29:17 UTC
*** Bug 385432 has been marked as a duplicate of this bug. ***
Comment 3 ryan 2017-12-01 16:11:47 UTC
(In reply to Boudewijn Rempt from comment #1)
> Can you please provide the link to that other bug so we can see whether it's
> a duplicate?
> 
> Also, this isn't exactly an easy set of steps to reproduce, so can you
> please be a bit more clear? I cannot follow this.

All I am doing is creating a selection around an image so I can copy the contents of the selection. Since many things need to be copied, I am trying to use the same vector selection to copy other pixels on the canvas since I can move the vector selection around.

What isn't working is the clipboard. It will not replace the first copy that I did, making it useless to use the same vector selection for copying of other unique pixels.
Comment 4 mvowada 2018-01-21 21:20:33 UTC
Hi ryan,
would you mind to list the steps or show them in a short video to attach here?
I'm sorry, but I'm still not sure how to reproduce your issue correctly. Thanks!
Comment 5 ryan 2018-02-26 20:53:43 UTC
(In reply to mvowada from comment #4)
> Hi ryan,
> would you mind to list the steps or show them in a short video to attach
> here?
> I'm sorry, but I'm still not sure how to reproduce your issue correctly.
> Thanks!

Here is a short video of the copy and paste issue. As you can see in the video, I am unable to copy new data using the same rectangle. It is also a very slow experience overall.
https://www.dropbox.com/s/npyelik71w85aem/vector_select_copy_paste_bug.mp4?dl=0
Comment 6 mvowada 2018-02-27 18:12:25 UTC
Created attachment 111061 [details]
(Video Example)

Thanks, I can reproduce the issue with Krita 4 beta on Ubuntu 14.04. 
No problems with Krita 3.3.3. (See video):

    1) "J" key
    2) "Tool Options" > Mode: "Vector Selection"
    3) click & drag to canvas select
    4) "CTRL+C" + "CTRL+V" (copy-paste)
    5) Toolbox > "Select Shapes Tool" (arrow)
    6) move the selection
    7) click outside the selection outline
    8) "CTRL+C" + "CTRL+V" (copy-paste)

Actual Results: empty paste
Expected Results: paste the copied canvas
Comment 7 mvowada 2018-02-27 18:13:45 UTC
(Confirming)
Comment 8 mvowada 2018-02-27 22:27:35 UTC
I apologize, I just realized that I forgot to select the level to copy and so the selection once pasted was empty. I have to change the status back to "Unconfirmed", I'm sorry.
Comment 9 ryan 2018-03-02 11:53:01 UTC
It is strange that you cannot verify the bug. I have tried krita 3.3.x on 3 different machines. Krita was tested on one machine with 3 different OS, including Ubuntu 16.04, Windows 7, and Windows 10. The other two machines use Windows 7 and Windows 10. All 64 bit OS.

In addition to my tests, I have verified the bug with another user on the IRC chat room. So that makes 4 computers with different hardware configurations.

All of my computers have motherboards and CPUs that are from 2009-2013.

In addition, the bug I reported several months ago regarding the non moving vector select, as well as the failed copy pastes can be seen the the latest stable build. See This video: 
https://www.dropbox.com/s/49k7xam8xweliaf/vector_select_krita.3.3.3.bug.mp4?dl=0
Comment 10 mvowada 2018-03-02 14:55:31 UTC
Created attachment 111141 [details]
(Video: vector selection copy paste working after moving)

(In reply to ryan from comment #9)
> See This video
Hi ryan, thanks for the example.
One-click outside the selection, just before copying, and it works here (see the steps in the video attachment).
Both in Krita 3.3.3 and 4 Beta versions.
Comment 11 Halla Rempt 2018-10-09 09:04:28 UTC
After the selection refactoring of September, this is no longer reproducible.
Comment 12 Halla Rempt 2018-10-09 13:45:59 UTC
So, let's close the bug.
Comment 13 ryan 2018-10-09 14:20:55 UTC
(In reply to Boudewijn Rempt from comment #12)
> So, let's close the bug.

Vector selections cannot be manipulated with the select shapes tool anymore. Seems like the feature was disabled with no alternative put in place.

That's one way to resolve a bug.
Comment 14 ryan 2018-10-09 14:33:12 UTC
Since this feature is disabled, could I request that this not be included in the "bug resolved" report for the donor feedback report. I don't think this really qualifies to make it on the list.
Comment 15 Halla Rempt 2018-10-09 14:43:06 UTC
They now can be directly manipulated with the selection tools, so it's actually become easier to work with them.
Comment 16 ryan 2018-10-09 15:00:44 UTC
(In reply to Boudewijn Rempt from comment #15)
> They now can be directly manipulated with the selection tools, so it's
> actually become easier to work with them.

I am unable to manipulate them at all unless I select "show global selection mask" and manipulate the layer. I was able to do this before.

Is there some other tool I am missing?
Comment 18 ryan 2018-10-09 16:07:44 UTC
(In reply to Boudewijn Rempt from comment #17)
> Please test with the current nightly builds:
> https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/ or
> https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/

I don't get what I'm supposed to look for. Am I supposed to be able to manipulate the selections using the "Select Shapes Tool" like I was able to do before the revision? If so, I can't. It says it only works on vector layers.

The only way I can move a selection around is by enabling "Show Global Selection Mask" in select menu. I was able to do this before any changes, so I'm unsure what is supposed to be "easier" in comparison.

Before the changes, the vector select enabled me to not only move, but resize the selection in real-time. It was buggy however, which is why I reported it.
Comment 19 Halla Rempt 2018-10-09 16:46:36 UTC
No, if you make a selection, and move the mouse into the selected area, you will automatically get a move cursor and be able to move the selection. Resize works as well, in the same way.
Comment 20 Halla Rempt 2018-10-09 16:46:55 UTC
Check out the video in https://krita.org/en/krita-4-2-release-notes/
Comment 21 ryan 2018-10-09 17:10:01 UTC
(In reply to Boudewijn Rempt from comment #20)
> Check out the video in https://krita.org/en/krita-4-2-release-notes/

I see, that is a better alternative. It behaves similar to Painter now which is very intuitive. I'm glad this approach is being used.

I agree that this should be marked as fixed and included as a bug fix.