Bug 385674 - libk3b/projects/datacd/k3bdatadoc.cpp:484: duplicate if condition ?
Summary: libk3b/projects/datacd/k3bdatadoc.cpp:484: duplicate if condition ?
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: Data Project (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-12 19:28 UTC by dcb314
Modified: 2017-10-13 03:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2017-10-12 19:28:11 UTC
[k3b-master/libk3b/projects/datacd/k3bdatadoc.cpp:484]: (style) Expression is always false because 'else if' condition matches previous condition at line 482.

            else if( e.text() == "extended" )
                d->isoOptions.setWhiteSpaceTreatment( K3b::IsoOptions::extended );
            else if( e.text() == "extended" )
                d->isoOptions.setWhiteSpaceTreatment( K3b::IsoOptions::replace );
Comment 1 Leslie Zhai 2017-10-13 03:06:23 UTC
Git commit d9c451f91bef3bc1c00a78081424f1be2c2ae65f by Leslie Zhai.
Committed on 13/10/2017 at 03:04.
Pushed by lesliezhai into branch 'master'.

[libk3b] Fix potential copy-paste issue.

A patch by dcb314@hotmail.com!

M  +1    -1    libk3b/projects/datacd/k3bdatadoc.cpp

https://commits.kde.org/k3b/d9c451f91bef3bc1c00a78081424f1be2c2ae65f