Bug 385516 - Loading Preview icon stuck
Summary: Loading Preview icon stuck
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.38.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 385120 386126 386145 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-09 12:27 UTC by Jasem Mutlaq
Modified: 2017-11-16 21:44 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Preview stuck (66.67 KB, image/png)
2017-10-09 12:27 UTC, Jasem Mutlaq
Details
Log file (27.95 KB, text/plain)
2017-10-09 16:40 UTC, Jasem Mutlaq
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jasem Mutlaq 2017-10-09 12:27:53 UTC
Created attachment 108240 [details]
Preview stuck

Get Hot New Stuff dialog used to display preview icons just fine. Now on 2 separate systems, it gets stuck on "Loading Preview" and the preview is never loaded. Using latest stuff from KDE Neon 16.04
Comment 1 Jasem Mutlaq 2017-10-09 16:40:18 UTC
Created attachment 108250 [details]
Log file

Result from this:

QT_LOGGING_RULES="org.kde.knewstuff*=true" kstars
Comment 2 Gabriel C 2017-10-18 11:01:09 UTC
commit  04cc49c71bdb948e06ccae2d97d7cc1a1d2f62af broke that ..

I can confirm reverting it makes things work again.

cookies to kbroulik ponintig to the wrong commit on IRC
Comment 3 Patrick Silva 2017-10-18 22:13:13 UTC
*** Bug 385120 has been marked as a duplicate of this bug. ***
Comment 4 Jasem Mutlaq 2017-10-22 05:57:51 UTC
Ok, so no updates on this? Should you then revert the offending commit that caused this?
Comment 5 Aleix Pol 2017-10-22 23:13:58 UTC
The patch is correct, reverting it would have other regressions. It's just a symptom of a different bug.
Comment 6 Patrick Silva 2017-10-24 03:59:24 UTC
*** Bug 386126 has been marked as a duplicate of this bug. ***
Comment 7 Jeremy Whiting 2017-10-24 21:24:30 UTC
Fixed in c32c8d002e1216373560c94738841a7a5e1b976b if we need to change it some other way to set the preview with a separate method that doesn't detach we can do that, but this fixes the issue here at least.
Comment 8 Patrick Silva 2017-10-26 19:42:37 UTC
*** Bug 386145 has been marked as a duplicate of this bug. ***
Comment 9 Robin 2017-11-16 15:46:45 UTC
Can I ask when this fix is due to be rolled out please? and if out already how do I apply it. Many Thanks in advance
Comment 10 Rog131 2017-11-16 21:44:01 UTC
(In reply to Robin from comment #9)
> Can I ask when this fix is due to be rolled out please? and if out already
> how do I apply it. Many Thanks in advance

Comment #7: https://bugs.kde.org/show_bug.cgi?id=385516#c7

Fixed with https://cgit.kde.org/knewstuff.git/commit/?id=c32c8d002e1216373560c94738841a7a5e1b976b

Part of The KDE Frameworks 5.40 - released: https://community.kde.org/Schedules -> https://community.kde.org/Schedules/Frameworks -> "Sat November 11th, 2017"

Upgrade to the KDE Frameworks 5.40.