Bug 385445 - Changing Focus to Password Dialog Upon Opening Vault from System Tray
Summary: Changing Focus to Password Dialog Upon Opening Vault from System Tray
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
: 386227 388571 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-06 18:35 UTC by Michael Tunnell
Modified: 2018-01-05 15:07 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tunnell 2017-10-06 18:35:49 UTC
While working on the Plasma 5.11 Release Video, I noticed that when I selected the option to "Open with File Manager" it would activate the password dialog. I expected that the dialog would be in focus immediately so I could start typing but instead the widget/applet keeps the focus.

In most situations in Plasma, I've noticed that when the password dialog is opened it takes focus to allow for immediate interaction so I think this Vault action should also utilize that approach as well.
Comment 1 Christoph Feck 2017-10-06 18:39:19 UTC
Could you check this command in Konsole:

kdialog --password Test

If it also happens there, then you are still using KF5 5.37, and it is a duplicate of bug 383653.
Comment 2 Ivan Čukić 2017-10-06 20:12:50 UTC
I'll see what the problem is
Comment 3 Michael Tunnell 2017-10-06 22:45:30 UTC
@Christoph Feck

I tried what you suggested and it worked fine. I used KDE Neon Git Stable in order to do the testing so I would assume it has the latest versions of everything since the beta.
Comment 4 cryptodude 2017-10-20 11:51:02 UTC
I'm observing this too. And I have the latest release.

What I'm seeing is that when I click on the 'Open with File Manager' button, it correctly opens the kdialog, and it correctly has a blinking cursor in the password field.

The problem is that the plasma widget (which I have on a panel) did not close. And as such my window focus is not on the newly opened window.

Exactly the same issue happens when I click on "create a new vault" button.

Is it possible to tell plasma to close the applet popop?  If I open the network manager and click on the "configure" button, the System Settings" opens and my applet closes, making the window-focus move as expected.
Comment 5 Nate Graham 2017-10-27 01:42:04 UTC
*** Bug 386227 has been marked as a duplicate of this bug. ***
Comment 6 Ivan Čukić 2017-12-09 06:29:27 UTC
Git commit b80ee599b39f0ffeb3bc749d9bcbc8cf592ea146 by Ivan Čukić, on behalf of Kees vd Broek.
Committed on 09/12/2017 at 06:29.
Pushed by ivan into branch 'master'.

Fix PWD dialog

Summary:
Make password dialog have error-handling built in.
Related: bug 385985

This will show the error directly in the dialog and refuse to close
until the mount was successful (or user presses cancel).

Test Plan: {F5518252}

Reviewers: #plasma, ivan

Subscribers: abetts, colomar, jensreuterberg, ngraham, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8787

M  +2    -0    kded/CMakeLists.txt
M  +6    -45   kded/service.cpp
A  +59   -0    kded/ui/mountdialog.cpp     [License: GPL (v2/3)]
A  +46   -0    kded/ui/mountdialog.h     [License: GPL (v2/3)]
A  +181  -0    kded/ui/mountdialog.ui

https://commits.kde.org/plasma-vault/b80ee599b39f0ffeb3bc749d9bcbc8cf592ea146
Comment 7 Nate Graham 2018-01-05 15:07:36 UTC
*** Bug 388571 has been marked as a duplicate of this bug. ***