Bug 385443 - 'Auto toggle parents' unnatural behavior when removing a tag
Summary: 'Auto toggle parents' unnatural behavior when removing a tag
Status: REPORTED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (show other bugs)
Version: 8.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-06 16:58 UTC by Sebas
Modified: 2023-05-04 19:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebas 2017-10-06 16:58:21 UTC
An auto toggle feature is being offered in Digikam tagging. Settings it to 'parents' makes Digikam behave like many other programs do. At least, that is for adding a tag. When removing a tag, it behaves very different as one would expect, especially compared to other programs: the whole tree is deleted. While technically this is inline with the description, a more natural way would be to only delete the chosen tag and its children. That's how most programs work.

In other words, I am suggesting this possibility/setting:
* When adding a tag, add that tag and its parents.
* When removing a tag, remove that tag and its children.
Comment 1 caulier.gilles 2020-08-04 08:23:22 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Best Regards

Gilles Caulier
Comment 2 Sebas 2020-08-04 14:01:35 UTC
This still applies. It is unnatural.
Comment 3 Blomi 2021-06-27 11:43:49 UTC
I backup Sebas concerns. The setting of tags works pretty fine.
But the removing is not intuitive.

Let's take the following example to illustrate:
[ ] Grandparent
   [ ] Parent1
      [ ] Child1
      [ ] Child2
   [ ] Parent2
      [ ] Child3
      [ ] Child4

The "toggle auto" setting is set to "parent".

I select Child1 and Child3. Result (with digikam 7.2.0):
[X] Grandparent
   [X] Parent1
      [X] Child1
      [ ] Child2
   [X] Parent2
      [X] Child3
      [ ] Child4

So far fine.

Now I realize Child3 was a mistake and I deselect it. What happens:
[ ] Grandparent
   [X] Parent1
      [X] Child1
      [ ] Child2
   [ ] Parent2
      [ ] Child3
      [ ] Child4
Now Parent1 is active without the Grandparent being active.
What I would expect (maybe as optional feature):
[X] Grandparent
   [X] Parent1
      [X] Child1
      [ ] Child2
   [ ] Parent2
      [ ] Child3
      [ ] Child4

So I would change Sebas rule
* When removing a tag, remove that tag and its children.
to
* When removing a tag, remove that tag and its children and its parents if these have no other child elements active.
Comment 4 caulier.gilles 2023-05-04 03:08:33 UTC
@sebas,

digiKam 8.0.0 is out. This entry still valid with this release ?

Best regards

Gilles Caulier
Comment 5 Sebas 2023-05-04 18:58:04 UTC
(In reply to caulier.gilles from comment #4)
> @sebas,
> 
> digiKam 8.0.0 is out. This entry still valid with this release ?
> 
> Best regards
> 
> Gilles Caulier

Hey,
Yes this still applies.