Bug 385410 - s390x: z13 vector string instructions not implemented
Summary: s390x: z13 vector string instructions not implemented
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 17:57 UTC by Andreas Arnez
Modified: 2018-09-26 17:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Vector string support for s390x z13 (464.24 KB, patch)
2018-01-11 04:43 UTC, Vadim Barkov 		Details
Vector string support for s390x z13 (476.39 KB, patch)
2018-01-28 16:58 UTC, Vadim Barkov 		Details
Vector string support for s390x z13 (278.20 KB, patch)
2018-07-25 18:35 UTC, Vadim Barkov 		Details
Show Obsolete (2) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Arnez 2017-10-05 17:57:27 UTC 
Valgrind currently lacks support for the z/Architecture vector string instructions introduced with z13.  These are documented in the z/Architecture Principles of Operation, Eleventh Edition (March, 2015), chapter 23: "Vector String Instructions".
Comment 1 Vadim Barkov 2017-10-15 11:17:08 UTC 
Note that I will submit patch after closing 385408 issue. The reason to do so is to avoid code dublicating.
Comment 2 Vadim Barkov 2018-01-11 04:43:28 UTC 
Created attachment 109789 [details]
Vector string support for s390x z13

Vector string patch:

It is supposed to be applied after this attachment 109672 [details] from the bug 385408. Please check it out.
Comment 3 Vadim Barkov 2018-01-12 07:55:12 UTC 
Since the "support" patch is merged this "string" patch can be applied directly to master.
Comment 4 Vadim Barkov 2018-01-28 16:58:06 UTC 
Created attachment 110181 [details]
Vector string support for s390x z13

Changes:

Verified the fact that this patch can be applied on master
Small optimization for VPKS and VPKLS
Comment 5 Vadim Barkov 2018-02-04 21:19:24 UTC 
Please not that last attachment 110181 [details] has been merged into "vector integer" one (located in bug 385409).

The reason to do so is that it's small and code from here is used in "vector integer" patch.
Comment 6 Vadim Barkov 2018-07-25 18:35:23 UTC 
Created attachment 114121 [details]
Vector string support for s390x z13

Changes:

Now this patch can be applied on master (on d44563c49e55f47016e23591f708c7aa57f7a098 or later commit)
Comment 7 Andreas Arnez 2018-09-26 17:35:57 UTC 
This is fixed by the patches discussed in Bug 385409, which have been pushed upstream now.