Bug 385369 - Brush preset overwriting doesn't work well on master
Summary: Brush preset overwriting doesn't work well on master
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Resource Management (show other bugs)
Version: git master (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-10-04 17:26 UTC by radian
Modified: 2018-10-04 11:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description radian 2017-10-04 17:26:06 UTC
- it doesn't save backup
- it blacklist wrong preset


As I know overwriting should rename old preset and create new preset with actual settings, then add old one to the blacklist.
But now it doesn't create backup and add overwritten (new) preset to blacklist.
Comment 1 Halla Rempt 2017-11-26 15:34:42 UTC
Hi Rad,

You need to be more explicit, because when I try to follow your directions, everything works:

I modified a preset, saved it, modified and saved it. I now have the following blacklist:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE m_blackListFile>
<resourceFilesList>
 <file>
  <name>~/.local/share/krita/paintoppresets/Airbrush_eraser_backup_2017-11-26-16:31:04.kpp</name>
 </file>
 <file>
  <name>~/dev/i-krita/share/krita/paintoppresets/Airbrush_eraser.kpp</name>
 </file>
 <file>
  <name>~/.local/share/krita/paintoppresets/Airbrush_eraser_backup_2017-11-26-16:31:13.kpp</name>
 </file>
</resourceFilesList>
            
Which is correct. Then I checked the presets folder:

boud@linux-s09k:~/.local/share/krita> ls paintoppresets/
Airbrush_eraser_backup_2017-11-26-16:31:04.kpp  Airbrush_eraser.kpp
Airbrush_eraser_backup_2017-11-26-16:31:13.kpp

Then I checked in Krita, and the correct version was loaded.
Comment 2 radian 2017-11-28 09:36:52 UTC
I modified "Airbrush_linear", clicked owerwrite, restart krita, presets loaded with new settings and works fine.
In the blacklist file (didn't copy other lines):
<name>D:/krita/i/share/krita/paintoppresets/Airbrush_linear.kpp</name>  (install folder for builds)
Also there is Airbrush_linear preset file in user resource folder.

Then I changed and owerwrited this preset again, after restart it didn't load.
Blacklist file:

  <name>D:/krita/i/share/krita/paintoppresets/Airbrush_linear.kpp</name>
 </file>
 <file>
  <name>~/AppData/Roaming/krita/paintoppresets/Airbrush_linear.kpp</name>

And in paintoppresets only one "Airbrush_linear" preset file which is get blacklisted, no backup files in appdata nor in install resource folder.

If I delete last preset from blacklist it loads with correct settings.

Win 10, very fresh master build.
Comment 3 Andrew Crouthamel 2018-09-28 02:38:32 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 radian 2018-10-04 11:03:34 UTC
Made a test with krita 4.1.3, everything work just fine.