Bug 385367 - K3b should not use "/tmp" as default path to save DVD/VCD rips
Summary: K3b should not use "/tmp" as default path to save DVD/VCD rips
Status: REOPENED
Alias: None
Product: k3b
Classification: Applications
Component: GUI/Usability (show other bugs)
Version: 19.12
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-04 16:30 UTC by Patrick Silva
Modified: 2020-02-20 18:46 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-10-04 16:30:16 UTC
Hi Leslie
Can you change it to "/home/username" please? Or maybe "/home/username/Videos"?
Comment 1 Nate Graham 2017-10-10 03:16:54 UTC
Patch available at https://phabricator.kde.org/D8231
Comment 2 Leslie Zhai 2017-10-13 02:54:00 UTC
Hi Nate,

Thanks for your patch!

Regards,
Leslie Zhai
Comment 3 Nate Graham 2017-10-24 15:20:08 UTC
Git commit 087d694664ad63cd598029cd74acc49cb1e9595b by Nathaniel Graham.
Committed on 24/10/2017 at 15:19.
Pushed by ngraham into branch 'master'.

Change default save path to ~/Videos

Summary:

Changed default save path to ~/Videos, which seems like a more humane starting location than /var/tmp.

Test Plan: Can't test; don't have any machines with optical drives. Would appreciate some rudimentary testing from anyone with appropriate hardware.

Reviewers: #kde_applications, lesliezhai, ltoscano

Reviewed By: lesliezhai

Subscribers: ltoscano

Differential Revision: https://phabricator.kde.org/D8231

M  +9    -2    src/rip/k3bvideocdrippingoptions.h

https://commits.kde.org/k3b/087d694664ad63cd598029cd74acc49cb1e9595b
Comment 4 Patrick Silva 2017-11-18 02:53:59 UTC
not fixed in 17.12 beta installed on Arch Linux.
Comment 5 Patrick Silva 2017-11-18 03:56:22 UTC
I just noticed k3b also uses "/tmp" to save DVD rips.
Comment 6 Patrick Silva 2017-12-15 00:02:40 UTC
K3b 17.12 changelog says that this bug is fixed, but it's not.
Comment 7 Leslie Zhai 2017-12-15 00:42:42 UTC
(In reply to Dr. Chapatin from comment #5)
> I just noticed k3b also uses "/tmp" to save DVD rips.

Hi Nate Graham,

Welcome patch, thanks a lot!
Comment 8 Leslie Zhai 2017-12-15 00:46:54 UTC
(In reply to Dr. Chapatin from comment #6)
> K3b 17.12 changelog says that this bug is fixed, but it's not.

There is *NO* log related to PR385367 https://github.com/KDE/k3b/blob/master/ChangeLog and PR384117 is Changes, not Bugfixes! please keep seeking truth from facts, I hate lie!
Comment 9 Patrick Silva 2017-12-15 00:58:37 UTC
hi Leslie
I talked about this changelog
https://www.kde.org/announcements/fulllog_applications.php?version=17.12.0#k3b
Comment 10 Leslie Zhai 2017-12-15 01:01:55 UTC
(In reply to Dr. Chapatin from comment #9)
> hi Leslie
> I talked about this changelog
> https://www.kde.org/announcements/fulllog_applications.php?version=17.12.
> 0#k3b

I have *NO* idea who wrote it, but please follow the https://github.com/kde/k3b thanks!
Comment 11 Nate Graham 2017-12-16 17:38:48 UTC
Sorry, I'm afraid I can't contribute much to K3b as I don't have any hardware with a disc drive.

Also, Leslie, if K3b is distributed through KDE Applications, then you should work with the release team to write the release notes for each release.
Comment 12 Leslie Zhai 2017-12-17 01:18:06 UTC
(In reply to Nate Graham from comment #11)
> Also, Leslie, if K3b is distributed through KDE Applications, then you
> should work with the release team to write the release notes for each
> release.

Thanks for your advise! but I don't have received notification email or should I follow which mailinglist?
Comment 13 Nate Graham 2017-12-17 17:07:25 UTC
kde-devel@kde.org is probably a good start. That's where I found out about it.
Comment 14 Leslie Zhai 2017-12-18 02:46:47 UTC
Git commit 92e20a4b144e5306838eb348bb14bdbada41d616 by Leslie Zhai.
Committed on 18/12/2017 at 02:45.
Pushed by lesliezhai into branch 'master'.

Change default save path to $HOME/Videos or fallback $HOME instead of /tmp or /var/tmp

M  +8    -2    libk3b/core/k3bglobalsettings.cpp
M  +4    -9    src/rip/k3bvideocdrippingoptions.h

https://commits.kde.org/k3b/92e20a4b144e5306838eb348bb14bdbada41d616
Comment 15 Christoph Feck 2018-01-02 02:00:38 UTC
Any reason bug fixes are not committed to the stable branch 'Applications/17.12'?

Regarding releases, we release KDE Applicatiosn every four months since several years already. For details, check the KDE release schedules.
Comment 16 Patrick Silva 2018-01-02 02:44:38 UTC
I just installed k3b-git on Arch Linux.
This bug persists (tested a DVD disc).
Comment 17 Leslie Zhai 2018-01-02 12:24:14 UTC
(In reply to Leslie Zhai from comment #14)
> Git commit 92e20a4b144e5306838eb348bb14bdbada41d616 by Leslie Zhai.
> Committed on 18/12/2017 at 02:45.
> Pushed by lesliezhai into branch 'master'.
> 
> Change default save path to $HOME/Videos or fallback $HOME instead of /tmp
> or /var/tmp
> 
> M  +8    -2    libk3b/core/k3bglobalsettings.cpp
> M  +4    -9    src/rip/k3bvideocdrippingoptions.h
> 
> https://commits.kde.org/k3b/92e20a4b144e5306838eb348bb14bdbada41d616

Hi Dr. Chapatin,

This commit fixed the issue "k3b also uses "/tmp" to save DVD rips".

Regards,
Leslie Zhai
Comment 18 Patrick Silva 2018-01-08 18:37:04 UTC
Today I installed k3b-git on Arch Linux.
The problem described here is still happening.
Comment 19 Leslie Zhai 2018-01-09 02:10:12 UTC
(In reply to Dr. Chapatin from comment #18)
> Today I installed k3b-git on Arch Linux.
> The problem described here is still happening.

Then you need to push ArchLinux packager :)
Comment 20 Patrick Silva 2018-03-31 15:49:25 UTC
K3b 18.04 beta has the same bug on Arch Linux.
Comment 21 Leslie Zhai 2018-08-28 11:46:14 UTC
*** Bug 397930 has been marked as a duplicate of this bug. ***
Comment 22 gabriele.ciuti@gmail.com 2018-08-30 09:27:15 UTC
hello
thanks for the patch... but..
the question is: this works also if I rip a bluray for only data (simple files..) ?
and moreover: I've not so space also in /home/Video folder to burn a 25Gb blueray disk, so I'd like to use a different folder in another HDD. 

I tried to specify different folder in the preferences section of K3b, but It doesen't work.

any idea