Bug 385299 - "X" button from the red box that shows warnings/errors messages needs better contrast
Summary: "X" button from the red box that shows warnings/errors messages needs better ...
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: 5.12.4
Platform: Archlinux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
Depends on:
Reported: 2017-10-02 16:01 UTC by Patrick Silva
Modified: 2018-05-08 13:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

screenshot (31.10 KB, image/png)
2017-10-02 16:01 UTC, Patrick Silva

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-10-02 16:01:18 UTC
Created attachment 108130 [details]

My summary says by itself, see the screenshot.
Comment 1 Patrick Silva 2018-04-19 18:18:03 UTC
Same on Arch, plasma 5.12.4.
Comment 2 Nate Graham 2018-05-08 13:14:37 UTC
Git commit 00bce130d35e9dc398709e690a05f8dde70f52b3 by Nathaniel Graham.
Committed on 08/05/2018 at 13:14.
Pushed by ngraham into branch 'master'.

Make KMessageWidget match Kirigami inlineMessage's style

This patch makes the venerable and wonderful `KMessageWidget` match the slick style of Kirigami's new `inlineMessage` control. As a by-product, it fixes a few usability bugs.

I didn't implement the drop shadow here because I couldn't get it to look right.
Related: bug 381255

Test Plan:
Spectacle, Breeze light, information:

Spectacle, Breeze dark, information:

Spectacle, Breeze light, positive:

Spectacle, Breeze dark, positive:

Dolphin, Breeze light, negative:

Dolphin, Breeze dark, negative:

Dolphin, Breeze light, warning:

Konsole, Breeze light with dark profile theme, warning:

Konsole, Breeze dark with light profile theme, information:

Konsole, Breeze light, information:

Kate, Breeze light, positive:

Kate, Breeze dark, information:

Reviewers: hein, #plasma, #vdg, elvisangelaccio, cfeck

Reviewed By: hein, #plasma, cfeck

Subscribers: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D12508

M  +34   -46   src/kmessagewidget.cpp
M  +2    -0    src/kmessagewidget.h