Bug 385288 - oversized cmakebuilddir dialog (width)
Summary: oversized cmakebuilddir dialog (width)
Status: CONFIRMED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: CMake (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: NOR grave
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
: 387136 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-02 08:51 UTC by RJVB
Modified: 2024-02-08 12:01 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
cmake import wizard width issue (35.68 KB, image/png)
2017-10-02 08:51 UTC, RJVB
Details
screenshot of the dialog taken with the "window under cursor" option (42.40 KB, image/png)
2017-10-02 08:55 UTC, RJVB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2017-10-02 08:51:52 UTC
Created attachment 108125 [details]
cmake import wizard width issue

On my Linux system the cmake configuration dialog when importing a new cmake-based project is completely oversized horizontally. This is probably related to a very long cmake "extra arguments" list I have somewhere in my history.

There should be some kind of protection against that because this clearly triggers issues in KWin and/or Qt itself. Curiously it doesn't happen on Mac but that can just mean I don't have the same extra arguments list in my history there.

One approach would be to limit the width of all widgets in the dialog to the width of the screen they're on, or we could fix the width entirely (using the Designer?)

This glitch puts the dialog buttons out of reach for me, which makes it a severe bug.
Comment 1 RJVB 2017-10-02 08:52:50 UTC
Comment on attachment 108125 [details]
cmake import wizard width issue

That image is a screenshot spanning the entire width of my screen.
Comment 2 RJVB 2017-10-02 08:55:41 UTC
Created attachment 108126 [details]
screenshot of the dialog taken with the "window under cursor" option

That image is 13933 pixels wide.
Comment 3 RJVB 2017-10-02 09:16:20 UTC
Junior job? Will it be that much work to fix this?
Comment 4 Kevin Funk 2017-10-02 09:20:28 UTC
What are you trying to imply with that question?
Comment 5 RJVB 2017-10-02 09:28:30 UTC
I'm not trying to imply anything. Labelling a fix as a junior job suggests that it'll be more work to come up with one than I'd have thought (and hoped).
Comment 6 Kevin Funk 2017-10-02 10:09:21 UTC
Labeling a fix as junior only suggests this is a good tasks for newcomers to pick up. That is, these tasks don't require huge knowledge about the issue context and can be fixed with relatively low amount of effort.
Comment 7 RJVB 2017-10-04 09:00:02 UTC
OK. I would have hoped that it's a question of 1 or 2 magic calls at the right spot, but you're right. This is exactly the sort of thing that might take junior a sizeable amount of time to get right (and also require patience that isn't always something that goes hand in hand with youth ;) )

Anyway, the issue is indeed somewhere in CMakeExtraArgumentsHistory . I can recall that I struggled a bit myself getting the widget to show at a proper size, well aligned with the others. I'll have another look at that code, and may figure out a way to ensure the dialog never goes wider than the screen it's on.


Side-ways related: would it be possible to abort the whole import procedure when you cancel this dialog, instead of continuing the procedure with (I presume) default settings?
Comment 8 Kevin Funk 2017-10-04 09:35:35 UTC
Can we keep this focused on the reported bug, please?

The last five comments were again just noise, and didn't provide anything to help resolving this issue.
Comment 9 Ganesh H 2017-11-02 15:34:21 UTC
Hi,
I would like to reserve this bug as a start of my contribution.
Comment 10 RJVB 2017-11-02 15:56:03 UTC
Please put up a phab review as soon as you have a start of a fix, and post the link here. I really look forward to this being solved!
Comment 11 Kevin Funk 2017-11-23 15:23:35 UTC
*** Bug 387136 has been marked as a duplicate of this bug. ***
Comment 12 Benedikt Thiemer 2024-02-08 12:01:24 UTC
As of version 5.12.230804 I cannot replicate this anymore, no matter how long the entries in the argument history are.
This is because the entries are shortened automatically.

I would suggest changing the status to "RESOLVED" but won't change it myself as I am quite new here.