[investactivities.cpp:111]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:135]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:263]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:269]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:349]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:355]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:498]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' [investactivities.cpp:504]: (style) Redundant condition: isMultiSelection(). '!A || (A && B)' is equivalent to '!A || B' First one is if (!isMultiSelection() || (isMultiSelection() && !cat->currentText().isEmpty())) {
Apparently, the automatic bug close did not work here. So I close it manually.
(In reply to Thomas Baumgart from comment #1) > Apparently, the automatic bug close did not work here. So I close it > manually. No, I just noticed, that I still need to push it. Shame on me.
Git commit e53ee0804bc71d309e955ce39141c8adf8e22d5f by Thomas Baumgart. Committed on 13/10/2018 at 16:34. Pushed by tbaumgart into branch '5.0'. Simplify logical expressions in source code FIXED-IN: 5.0.2 M +8 -8 kmymoney/dialogs/investactivities.cpp https://commits.kde.org/kmymoney/e53ee0804bc71d309e955ce39141c8adf8e22d5f