Bug 385050 - JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"
Summary: JJ: workflow improvement: create a group when several layers are selected and...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 3.1.2
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2017-09-25 11:49 UTC by gordie.lachance+dev
Modified: 2018-05-02 11:57 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
file changed in kis_layer_box.cpp and kis_layer_box.h (1.73 KB, patch)
2018-02-09 08:42 UTC, shubhamgoyal
Details
Proposed patch (1.94 KB, patch)
2018-03-18 18:37 UTC, Seoras Macdonald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gordie.lachance+dev 2017-09-25 11:49:44 UTC
Hi !
Small idea here that could be great:

When the user selects several layers in the layers stack and clicks on the "add layer" (+) icon; it would be great to automatically create a layer group and move the selected layers inside that new group.

What do you think of it ?
Comment 1 Halla Rempt 2017-09-27 07:58:10 UTC
Yes, this is very sensible and should be really easy to implement. Confirming, and setting to junior job. It would be perfect for a gsoc or sok student to get started on.
Comment 2 rishabh.chakrabarti 2017-09-27 23:44:08 UTC
Hi, can I take this up?
Comment 3 Halla Rempt 2017-09-28 08:08:06 UTC
Yes, sure! If you have questions, please join us on #krita on irc.
Comment 4 simeirxh 2017-11-02 20:42:18 UTC
(In reply to rishabh.chakrabarti from comment #2)
> Hi, can I take this up?

Hello, Rishabh. There hasn't been an update for a while, so I wonder how you are making progress on this. If you are busy dealing with something else, I want to take this up.
Comment 5 shubhamgoyal 2018-02-09 08:42:01 UTC
Created attachment 110480 [details]
file changed in kis_layer_box.cpp and kis_layer_box.h

What's the problem with the code. please explain.
Comment 6 Halla Rempt 2018-02-09 12:12:45 UTC
You're creating a new action every time the button is clicked, instead of triggering the action.
Comment 7 Seoras Macdonald 2018-03-18 18:37:15 UTC
Created attachment 111486 [details]
Proposed patch

Hi, I think I've got a working patch based on the previous patch attached by  shubhamgoyal. This is my first time submitting a patch, so I'm not sure if this is the most natural way to implement the feature though.
Comment 8 Dmitry Kazakov 2018-04-18 08:49:06 UTC
Git commit c7ddbf1a0145d1c9a1fea01778df709c508f7c80 by Dmitry Kazakov, on behalf of Seoras Macdonald.
Committed on 18/04/2018 at 08:48.
Pushed by dkazakov into branch 'master'.

Change the behaviour of the add layer button

Summary:
In the layers docker, if more than 1 layer is selected, then
the add layer button now creates a quick group for the selected
layers.
Reviewers: #krita, rempt
Reviewed By: #krita, rempt
Subscribers: alvinhochun, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D11507

M  +16   -1    plugins/dockers/defaultdockers/kis_layer_box.cpp
M  +2    -0    plugins/dockers/defaultdockers/kis_layer_box.h

https://commits.kde.org/krita/c7ddbf1a0145d1c9a1fea01778df709c508f7c80
Comment 9 Halla Rempt 2018-05-02 11:57:40 UTC
Git commit 3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d by Boudewijn Rempt, on behalf of Seoras Macdonald.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Change the behaviour of the add layer button

Summary:
In the layers docker, if more than 1 layer is selected, then
the add layer button now creates a quick group for the selected
layers.
Reviewers: #krita, rempt
Reviewed By: #krita, rempt
Subscribers: alvinhochun, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D11507

(cherry picked from commit 77d75e3d811add37b909683d61ad8e779f8524e1)

M  +16   -1    plugins/dockers/defaultdockers/kis_layer_box.cpp
M  +2    -0    plugins/dockers/defaultdockers/kis_layer_box.h

https://commits.kde.org/krita/3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d