Bug 385035 - Text in the fit mode segmented control's middle button frequently overflows
Summary: Text in the fit mode segmented control's middle button frequently overflows
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-24 23:34 UTC by Patrick Silva
Modified: 2017-10-15 19:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (11.88 KB, image/png)
2017-09-24 23:34 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-09-24 23:34:41 UTC
Created attachment 108001 [details]
screenshot

Gwenview on neon dev unstable...
See the screenshot please.
Comment 1 Nate Graham 2017-09-29 21:52:53 UTC
It looks lousy in English, too. We'll need to make the button (or all of them) grow as necessary
Comment 2 null 2017-10-15 10:00:36 UTC
Proposal for patch (please comment which of the options you like better): https://phabricator.kde.org/D8306
Comment 3 null 2017-10-15 19:34:09 UTC
Git commit 7389aa55dbdf9c8af95106498aa6ce082cc03eb2 by Henrik Fehlauer.
Committed on 15/10/2017 at 19:33.
Pushed by rkflx into branch 'Applications/17.08'.

Fix padding of "Fit Width" button

Summary:
3e10699ac37c4 introduced "Fit to Width", but failed to adapt the width
calculation of the zoom mode buttons in the bottom zoom widget bar
accordingly. This resulted in the middle button getting its text cut off
for some languages, looking like this:

{F5431466}

There are several options to remedy this:
- Give equal width to all buttons
- Give equal width to the outer buttons (i.e. symmetric, probably the initial intention when there were only two buttons)
- Just respect the size hint of each button individually

| {F5431473} | {F5431474} | {F5431476} |

As the three buttons are already quite wide, in order not to impact the
minimal window size too much (rules out "equal width") and at the same
time not to make the "Fit" button for English too narrow (rules out
"individual width") we choose the "symmetric" option.

Test Plan:
Switch application language to Czech, view image. Text in "Fit to Width"
(i.e. middle) button not cut off anymore, minimal window size only
slightly impacted. For English, the "Fit" button is still wide enough.

Reviewers: #kde_applications, broulik

Reviewed By: broulik

Subscribers: broulik

Differential Revision: https://phabricator.kde.org/D8306

M  +0    -1    lib/zoomwidget.cpp

https://commits.kde.org/gwenview/7389aa55dbdf9c8af95106498aa6ce082cc03eb2
Comment 4 Nate Graham 2017-10-15 19:40:12 UTC
Fantastic. :)