Krita 3.3.0-rc.1 crashes when I try to add "toggle assistant" to the toolbar. After restarting Krita, "toggle assistant" is gone from the "Configure Toolbars>Available actions" menu but not present in "Current actions". After another restart, it appears in "Current actions," but it doesn't show on the toolbar. Removing it from "Current actions" and then adding it again results in another crash. I'll note that, in previous Krita versions, "toggle assistant" was one of the buttons that disappeared from the toolbar after every restart, as referenced in bug #365222.
I don't get a crash but I can confirm the rest of the weirdness: but that's a duplicate of bug 365222.
"toggle assisant" is an action created by the brush tool, which means it's only created when a document is created, after the gui is constructed.
Git commit f3605f3f77ea1fe1a1f2c2cb38931b38e78fb29e by Boudewijn Rempt. Committed on 28/09/2017 at 09:55. Pushed by rempt into branch 'krita/3.3'. Pass the action collection to the edit toolbar M +2 -1 libs/ui/KisMainWindow.cpp https://commits.kde.org/krita/f3605f3f77ea1fe1a1f2c2cb38931b38e78fb29e
Git commit 89c73f69e2c095c634e8df06dc169e18074dd20f by Boudewijn Rempt. Committed on 28/09/2017 at 10:06. Pushed by rempt into branch 'krita/3.3'. Use makeQAction, not new QAction for named action Any action with a name, that is defined in a .action file must be created with KisActioNRegistry::makeQAction, not new QAction. M +5 -5 plugins/tools/basictools/kis_tool_brush.cc https://commits.kde.org/krita/89c73f69e2c095c634e8df06dc169e18074dd20f
Git commit ca605c8607c8072300f76c62f3228b060520a9a9 by Boudewijn Rempt. Committed on 28/09/2017 at 11:08. Pushed by rempt into branch 'master'. Pass the action collection to the edit toolbar M +2 -1 libs/ui/KisMainWindow.cpp https://commits.kde.org/krita/ca605c8607c8072300f76c62f3228b060520a9a9
Git commit a254c1d5e145f716c9d0b8e592e32e83ed7c94ed by Boudewijn Rempt. Committed on 28/09/2017 at 11:09. Pushed by rempt into branch 'master'. Use makeQAction, not new QAction for named action Any action with a name, that is defined in a .action file must be created with KisActioNRegistry::makeQAction, not new QAction. M +4 -4 plugins/tools/basictools/kis_tool_brush.cc https://commits.kde.org/krita/a254c1d5e145f716c9d0b8e592e32e83ed7c94ed
This is practically unfixable without a big redesign. Another problem is that if you put the action on the toolbar, then create a second document, on selecting the second document the action is disabled because it is created per view, not for the window.
We'd need to make a plan for this: https://phabricator.kde.org/T4040
I see why it used to disappear then. But even though it would disappear from the toolbar, it would still show as a current action in the Configure Toolbars dialog next time you started Krita. You'd have to move it back to available actions and add it again each time. Not a huge problem. Just a minor annoyance. I'm still getting crashes on adding it though with the final release version of 3.3.0. Adding other toolbar options causes a crash as well, but when I restart Krita, those options are present on the toolbar. Toggle Assistant never shows at all. It also crashes for me when I remove the items I added from the toolbar.
(In reply to Autumn Lansing from comment #9) > I'm still getting crashes on adding it though with the final release version > of 3.3.0 Hi Autumn, I'm not able to reproduce the crash with "Krita 4.0.0-beta1.1.appimage" (Ubuntu 14.04). Please, could you check if you still get the crash with the latest Krita 4 version? thanks
It's still crashing for me. It's the exact same behavior in 4.0.0-beta1.1 as it was in my original report.
(Changing the report status back to "confirmed")
I still don't get a crash. If you start Krita from the terminal, is there any interesting output when you add the button to the toolbar?
Created attachment 109976 [details] krita crash core dump
All the command line tells me is: "/home/autumn/bin/krita: line 4: 7550 Segmentation fault (core dumped) /home/autumn/bin/krita/krita-4.0.0-beta1.1-x86_64.appimage" I've included a core dump as provided by Fedora's automated problem reporting system, if that will be helpful.
With the official 4.0.0 release, Krita no longer crashes when adding the Toggle Assistant to the toolbar. The Toggle Assistant still disappears between sessions, but as you said, that would take a big redesign to fix and it isn't a major issue. My reported bug, though, has been resolved.