Bug 384895 - Global menu is not screen aware
Summary: Global menu is not screen aware
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu (show other bugs)
Version: 5.10.5
Platform: Manjaro Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-20 17:00 UTC by Víctor
Modified: 2018-11-22 18:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
I'm using Kdevelop (right screen), but the items in the global menu also appears in the panel of the other screen (left). (66.93 KB, image/png)
2017-09-20 17:00 UTC, Víctor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor 2017-09-20 17:00:17 UTC
Created attachment 107917 [details]
I'm using Kdevelop (right screen), but the items in the global menu also appears in the panel of the other screen (left).

Greetings.

I'm using global menu widget in two panels, one panel per screen. When I'm using the window in the active screen, the global menu items also appears in the other screen. Maybe would be interesting add an option to avoid that the global menu items of my active window appears in the panel of other screen.
Comment 1 Michail Vourlakos 2018-11-06 12:37:53 UTC
I think that global menu model (https://github.com/KDE/plasma-workspace/blob/master/applets/appmenu/plugin/appmenumodel.cpp) should support screen awareness

@kbroulik what is your opinion, should I go for it?
Comment 2 Michail Vourlakos 2018-11-22 18:37:20 UTC
Git commit 3fa1cc6b77161a2bcc50647fa67311355f8e7534 by Michail Vourlakos.
Committed on 22/11/2018 at 18:37.
Pushed by mvourlakos into branch 'master'.

mage global menu screen aware

Summary:
--a new screenGeometry property is added in the
AppMenuModel in order to be used for filtering
windows based on their geometry.
Related: bug 395853

Test Plan:
--validate that when moving a window between different screens the global menu applet is updated accordingly
--checkout that nothing has broke because of this new behavior

Reviewers: #plasma, broulik, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16768

M  +2    -1    applets/appmenu/package/contents/ui/main.qml
M  +54   -2    applets/appmenu/plugin/appmenumodel.cpp
M  +19   -0    applets/appmenu/plugin/appmenumodel.h

https://commits.kde.org/plasma-workspace/3fa1cc6b77161a2bcc50647fa67311355f8e7534