Bug 384864 - Oxygen cursors have some reversed symlinks
Summary: Oxygen cursors have some reversed symlinks
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: icons (show other bugs)
Version: 5.10.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: pinheiro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-19 19:07 UTC by Jack
Modified: 2018-08-30 23:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2017-09-19 19:07:50 UTC
(originally reported to Gentoo bug list: https://bugs.gentoo.org/629550.

(I'm not sure if any of this is Gentoo specific, but I have confirmed the basic problem looking at the git source.)  Oxygen installs six folders under /usr/share/icons (KDE_Classic, Oxygen_Black, _Blue, _White, _Yellow, and _Zion).  Under each of those is a cursors folder.  In each of them col-resize is a symlink to split_v and row-resize is a symlink to split_h.  These links are backwards: col-resize should point to split_h (resizing a column is adjusting a split horizontally - that is side to side adjustment of a vertical split, thus perhaps the confusion) and row-resize should point to split_v.  If you look in /usr/share/icons/breeze_cursors (part of the Gentoo kde-plasma/breeze package) split_h points to col-resize and split_v points to row-resize, which is the correct matching.  (I don't think it matters which is the symlink and which is the real file, just that they are paired correctly.)
Comment 1 Andreas Sturmlechner 2017-09-25 10:08:05 UTC
(In reply to Jack from comment #0)
> (originally reported to Gentoo bug list: https://bugs.gentoo.org/629550.
> (I'm not sure if any of this is Gentoo specific

Gentoo installs a vanilla oxygen, no downstream patching going on.
Comment 2 Jack 2017-10-12 01:04:58 UTC
I have prepared a patch for Phabricator - who do I list as reviewer?  (It doesn't accept #oxygen.)
Comment 3 Christoph Feck 2017-10-12 15:02:52 UTC
I suggest to use the Plasma group as reviewer.
Comment 4 Jack 2017-10-12 16:12:54 UTC
Thanks.  https://phabricator.kde.org/D8267 submitted.
Comment 5 Jack 2018-08-01 18:55:05 UTC
Ping.  Is there a problem with my patch, or does everyone just think someone else will review it?
Comment 6 Jack 2018-08-30 23:02:32 UTC
Git commit 5bf9dfe906b50f2455210a29a00ec5494d8e26b7 by Jack Ostroff.
Committed on 30/08/2018 at 23:02.
Pushed by ostroffjh into branch 'master'.

Correcting symlinks between col- and row-resize and split_v and _h cursors

Summary: BUG: 384864

Reviewers: #plasma, apol, cfeck

Reviewed By: cfeck

Subscribers: davidedmundson, rdieter, tfoster, apol, asturmlechner, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8267

M  +1    -1    cursors/KDE_Classic/cursors/col-resize
M  +1    -1    cursors/KDE_Classic/cursors/row-resize
M  +1    -1    cursors/Oxygen_Black/cursors/col-resize
M  +1    -1    cursors/Oxygen_Black/cursors/row-resize
M  +1    -1    cursors/Oxygen_Blue/cursors/col-resize
M  +1    -1    cursors/Oxygen_Blue/cursors/row-resize
M  +1    -1    cursors/Oxygen_White/cursors/col-resize
M  +1    -1    cursors/Oxygen_White/cursors/row-resize
M  +1    -1    cursors/Oxygen_Yellow/cursors/col-resize
M  +1    -1    cursors/Oxygen_Yellow/cursors/row-resize
M  +1    -1    cursors/Oxygen_Zion/cursors/col-resize
M  +1    -1    cursors/Oxygen_Zion/cursors/row-resize
M  +1    -1    cursors/src/symlinks/col-resize
M  +1    -1    cursors/src/symlinks/row-resize

https://commits.kde.org/oxygen/5bf9dfe906b50f2455210a29a00ec5494d8e26b7