Bug 384747 - Task Manager: Sorting by Desktop doesnot work with grouped windows
Summary: Task Manager: Sorting by Desktop doesnot work with grouped windows
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.10.5
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords: reproducible, usability
Depends on:
Blocks:
 
Reported: 2017-09-15 15:31 UTC by guptaprashant504
Modified: 2018-03-13 11:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description guptaprashant504 2017-09-15 15:31:24 UTC
Hi I have Plasma 5.10.5 installed on Fedora 26.

In the task manager settings, I selected the "By Desktop" option in sorting and "By Program Name" in the grouping setting. But if there is an application group on Desktop 2 open(in my case, multiple PDFs in Okular) and I open Firefox on desktop 1, Firefox appears after the application group on the task manager. 

Proper sorting takes place if I don't enable application grouping.
Comment 1 guptaprashant504 2017-09-15 15:48:57 UTC
Just realized that this makes sense when opening the same application on different desktops. But the group can still be sorted if all the instances of the application group are on the same desktop.
Comment 2 Alexander Mentyu 2018-02-28 14:01:12 UTC
Grouped app windows always appear on most left position in the Task Manager - maybe this is as feature not a bug? all other non-grouped app windows appear in proper places on the Panel
Comment 3 Eike Hein 2018-03-12 09:00:07 UTC
This is a bug indeed.
Comment 4 Eike Hein 2018-03-12 09:36:06 UTC
Patch under review: https://phabricator.kde.org/D11257
Comment 5 Eike Hein 2018-03-13 11:58:38 UTC
Git commit a9df1e20f527dadcc43bcbbad48a9de52f83d9dd by Eike Hein.
Committed on 13/03/2018 at 11:58.
Pushed by hein into branch 'Plasma/5.12'.

Improve By Desktop sorting for task groups

Summary:
TaskGroupingProxyModel used to return QVariant() as the
AbstractTasksModel::VirtualDesktop role for task groups,
resulting in TasksModel to sort task groups indiscrimi-
nately at the front of the list. In this patch, it instead
returns the lowest virtual desktop found among the children.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11257

M  +15   -4    libtaskmanager/taskgroupingproxymodel.cpp

https://commits.kde.org/plasma-workspace/a9df1e20f527dadcc43bcbbad48a9de52f83d9dd