Suppose you have elements with IDs A and B. Then you try changing the element with ID B to have ID A. The dialog reports "The entered id 'B' is already in use for another entry." which is wrong, it should be A.
Created attachment 107942 [details] First attempt to fix bug Please apply this patch to Git master and see if it fixes your problem. This patch will also address the situation where the user clears the entry id or macro key, respectively.
I saw only after writing this patch and an answer to this bug report that you had proposed a patch on your own in phabricator: https://phabricator.kde.org/D7838 The patch in attachment 107942 [details] is more complex than your patch in D7838, but attachment 107942 [details] shines by having comments, showing the user both the original and the new id/key, and covering the problem of empty ids/keys. Therefore, I would go with attachment 107942 [details] as a solution to this bug, but please feel free to comment or suggest changes/improvements.
(In reply to Thomas Fischer from comment #2) > I saw only after writing this patch and an answer to this bug report that > you had proposed a patch on your own in phabricator: > https://phabricator.kde.org/D7838 > > The patch in attachment 107942 [details] is more complex than your patch in > D7838, but attachment 107942 [details] shines by having comments, showing > the user both the original and the new id/key, and covering the problem of > empty ids/keys. > Therefore, I would go with attachment 107942 [details] as a solution to this > bug, but please feel free to comment or suggest changes/improvements. Works for me.
Git commit 1f8a4d7577185c9c7028f9356cdc7526ea106236 by Thomas Fischer. Committed on 23/09/2017 at 19:24. Pushed by thomasfischer into branch 'master'. Handling of empty or duplicate entry ids or macro keys Improving the handling of empty entry ids or macro keys, respectively, or entry ids or macro keys, respectively, that are duplicates of existing entries' ids or macros' keys, respectively. For empty ids/keys, a warning is shown and the original (hopefully valid) id/key is restored. For duplicate ids/keys, the user is asked to choose between restoring the original id/key or keeping the new-but-duplicate id/key. M +56 -19 src/gui/element/elementeditor.cpp M +2 -3 src/gui/element/elementwidgets.cpp M +7 -1 src/gui/element/elementwidgets.h https://commits.kde.org/kbibtex/1f8a4d7577185c9c7028f9356cdc7526ea106236