Created attachment 107863 [details] qCDebug() is good enough, nothing to warn about here. A recent commit made the cmake project manager very spammy esp. during project import: warnings are printed for every unhandled received message, including the progress messages. There's no need for that feedback to have warning status. In fact, the function where this happens doesn't handle messages at all, only replies. If messages aren't handled elsewhere it really is rather pointless to print the feedback for each and every received message ... I haven't yet seen "unhandled reply" warnings from earlier in the processResponse() function; those can probably be demoted to debug level too.
A new spammy bit which doesn't print anything understandable or of interest, introduced by #11bc71c1 : diff --git a/plugins/cmake/cmakeutils.cpp b/plugins/cmake/cmakeutils.cpp index 9d6b6318d37281b7ec45673adfc9ce2ab322e202..5b9bd5fabe743b89252706ecb50abce0cb2aa350 100644 --- a/plugins/cmake/cmakeutils.cpp +++ b/plugins/cmake/cmakeutils.cpp @@ -716,6 +716,10 @@ QVector<Test> importTestSuites(const Path &buildDir) continue; } Test &test = tests.last(); + qWarning() << "ARGS"; + for (auto arg : entry.arguments) { + qWarning() << arg.value; + } for (int i = 2; i < entry.arguments.count(); i += 2) test.properties[entry.arguments[i].value] = entry.arguments[i + 1].value; }
Git commit 7c4e09c29ba52dd99149e8eba33e0d50815d88f9 by Kevin Funk. Committed on 04/10/2017 at 08:11. Pushed by kfunk into branch '5.2'. cmake: Degrade warning to normal debug msg Patch by RJVB, thanks! FIXED-IN: 5.2.0 M +1 -1 plugins/cmake/cmakeserverimportjob.cpp https://commits.kde.org/kdevelop/7c4e09c29ba52dd99149e8eba33e0d50815d88f9
Git commit 73f2759f5e85ef9335280e3f8bb33428ec0df5cd by Kevin Funk. Committed on 04/10/2017 at 09:05. Pushed by kfunk into branch '5.2'. Revert "cmake: Degrade warning to normal debug msg" Note: We should explicitly state the "ignored" messages in the code instead. Let's keep the warning for unknown + unhandled messages. Also, the 'progress' message is already handled properly now, so this unhandled message type is gone already. This reverts commit 7c4e09c29ba52dd99149e8eba33e0d50815d88f9. M +1 -1 plugins/cmake/cmakeserverimportjob.cpp https://commits.kde.org/kdevelop/73f2759f5e85ef9335280e3f8bb33428ec0df5cd
I beg to differ. It makes no sense to warn about unhandled cmake server messages for the majority of users (basically everyone not working on cmake server support). They're only useful when debugging an import issue, and can then be turned on easily enough.
Git commit b1bcf4ddbd841270a0b31a1d055ec4ead941b00d by Aleix Pol. Committed on 04/10/2017 at 10:53. Pushed by apol into branch '5.2'. Make cmake-server output forwarding a qCDebug M +2 -2 plugins/cmake/cmakeserverimportjob.cpp https://commits.kde.org/kdevelop/b1bcf4ddbd841270a0b31a1d055ec4ead941b00d