Bug 384485 - Face Regions are deleted when unconfirmed face suggestion is rejected by user
Summary: Face Regions are deleted when unconfirmed face suggestion is rejected by user
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 5.7.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-08 09:48 UTC by Sven
Modified: 2020-09-03 20:59 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments
Redundant buttons when face tagging? (70.29 KB, image/png)
2019-06-27 21:21 UTC, MarcP
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven 2017-09-08 09:48:56 UTC
When an unconfirmed face is rejected it should tagged as unknown and keep the face area.
But if one rejects a suggestion the face area is deleted.
Comment 1 Maik Qualmann 2018-11-15 13:40:59 UTC
And how should an invalid face area be deleted, if not by rejection? I see no mistake here, either give it a name or leave it as unknown. If it was unintentionally rejected, it is now also possible to search an album or a single image again for faces.

Maik
Comment 2 caulier.gilles 2019-03-20 15:15:56 UTC
After 3 weeks of work, i finally completed the compilation of AppImage using Qt
5.11.3 + QWebkit 5.212.

New 6.1.0 pre-release AppImage bundle can be found here (64 bits only for the
moment) :

https://files.kde.org/digikam/

Please check if this bugzilla entry still valid.

Thanks in advance

Gilles Caulier
Comment 3 MarcP 2019-06-27 15:41:52 UTC
I just noticed that bug too. It's still present in the last appimage (digikam-6.2.0-git-20190618T151249-qtwebkit-x86-64.appimage). 

If a suggestion from the "Unconfirmed" list is rejected, it means that that face does not belong to the person digikam thought it was. But it is still a face, so it should not be deleted altogether.

When rejecting a confirmation, the face should either return to the "Unknown" list, or try and suggest another name.

(also, currently "Unconfirmed/Suggested" faces appear in two places in the Personal panel: within the "Unconfirmed" list, and within each suggested person's. Maybe just the latter would be enough?)
Comment 4 Maik Qualmann 2019-06-27 21:08:22 UTC
The function was / is meant to reject things that were wrongly recognized as a face. For example, a car tire that has been recognized like a face must be able to be removed. It is not meant to reject a wrong suggestion. You can correct or ignore the suggestion.

Maik
Comment 5 MarcP 2019-06-27 21:20:42 UTC
Ok, but then it is misleading. Basically you have a text box showing you a name and asking whether it is right or wrong with big green and red buttons. Most people will assume that these buttons are meant to confirm if that face corresponds to that name, not whether that is a face or not. Specially when these two buttons and the name appear at the same time when the user clicks on that face.

Moreover, there is a X sign at the top right corner of each face that does exactly that, remove the face from the image, so the red "minus sign" button would be redundant.
Comment 6 MarcP 2019-06-27 21:21:15 UTC
Created attachment 121195 [details]
Redundant buttons when face tagging?
Comment 7 Maik Qualmann 2019-06-28 05:55:33 UTC
Of course we can assign different behavior to the two buttons. The round X removes the face, the minus button rejects the suggestion and assigns the item unknown again. At the moment I can not change it, we have a student who works on improving the face workflow. To prevent problems later merging the code, I have to avoid making changes to parts of the code where the student works.

Maik
Comment 8 caulier.gilles 2019-06-28 05:59:20 UTC
Maik,

Just CC with bugzilla Igor about this entry. Like this he will add this file to the list of tasks to do while the Face Workflow improvement project...

Gilles
Comment 9 caulier.gilles 2019-12-23 15:33:58 UTC
7.0.0-beta1 is out with new Face Recognition algorithm based on Deep
Learning/Neural Network API from OpenCV

https://download.kde.org/unstable/digikam/

Please test and give us a feedback

Thanks in advance
Gilles Caulier
Comment 10 Kartik 2020-03-19 18:46:27 UTC
On a somewhat related issue, whenever we delete a tag from a confirmed face. For eg. If I had confirmed a suggestion, but later realized it is incorrect. I will do a Remove Tag -> People/Kartik.

I think this should return the image back to unknown, however it rejects the image as a face. We will have to scan it again, to get it back to unknown.
Comment 11 Maik Qualmann 2020-03-20 14:11:43 UTC
*** Bug 419047 has been marked as a duplicate of this bug. ***
Comment 12 Kartik 2020-08-01 18:01:01 UTC
Gilles, this bug report may be closed now. I have implemented functionality, to reject Faces if the Red Minus Button is pressed.

Kartik
Comment 13 MarcP 2020-08-01 18:02:06 UTC
❤️